Bug 18368

Summary: DBversion 16.12.00.022 not set by updatedatabase.pl
Product: Koha Reporter: Marc Véron <veron>
Component: Installation and upgrade (web-based installer)Assignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: critical    
Priority: P5 - low CC: gmcharlt, katrin.fischer, kyle, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 17866    
Bug Blocks:    
Attachments: Bug 18368 - DBversion 16.12.00.022 not set by updatedatabase.pl
Bug 18368 - DBversion 16.12.00.022 not set by updatedatabase.pl
Bug 18368 - DBversion 16.12.00.022 not set by updatedatabase.pl

Description Marc Véron 2017-04-02 16:51:52 UTC

    
Comment 1 Marc Véron 2017-04-02 16:55:06 UTC
Updating to 16.12.00.22 puts the upgrade process in an endless loop because DBversione is not set by updatedatabase.pl
Missing line:  SetVersion( $DBversion )
Comment 2 Marc Véron 2017-04-02 17:03:26 UTC
Created attachment 61769 [details] [review]
Bug 18368 - DBversion 16.12.00.022 not set by updatedatabase.pl

Updating to 16.12.00.22 puts the upgrade process in an endless loop because DBversione is not set by updatedatabase.pl
Missing line:  SetVersion( $DBversion )

This patch inserts the line as appropriate.

To test:
- Apply patch
- Verify code change makes sense
- Verify that upgrade smoothly runs through
Comment 3 Mark Tompsett 2017-04-03 05:39:33 UTC
Created attachment 61773 [details] [review]
Bug 18368 - DBversion 16.12.00.022 not set by updatedatabase.pl

Updating to 16.12.00.22 puts the upgrade process in an endless loop because DBversione is not set by updatedatabase.pl
Missing line:  SetVersion( $DBversion )

This patch inserts the line as appropriate.

To test:
- Apply patch
- Verify code change makes sense
- Verify that upgrade smoothly runs through

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 4 Marcel de Rooy 2017-04-03 07:11:29 UTC
Created attachment 61775 [details] [review]
Bug 18368 - DBversion 16.12.00.022 not set by updatedatabase.pl

Updating to 16.12.00.22 puts the upgrade process in an endless loop because DBversione is not set by updatedatabase.pl
Missing line:  SetVersion( $DBversion )

This patch inserts the line as appropriate.

To test:
- Apply patch
- Verify code change makes sense
- Verify that upgrade smoothly runs through

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Kyle M Hall 2017-04-03 10:27:52 UTC
Pushed to master for 17.05, thanks Marc!
Comment 6 Katrin Fischer 2017-04-10 21:20:04 UTC
Please don't forget to set dependencies - they make a maintainer's job so much easier :)

This isn't relevant for 16.11.x as the depending bug 17866 is not in it.