Summary: | 404 errors on page causes SCO user to be logged out | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Self checkout | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | eugenegf, jonathan.druart, lucas, m.de.rooy, martin.renvoize, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.05
|
|
Circulation function: | |||
Bug Depends on: | 22641 | ||
Bug Blocks: | 23102 | ||
Attachments: |
Bug 18387: Allow sco-user to access errors templates
Bug 18387: Allow sco-user to access errors templates Bug 18387: (QA Follow up) adding specificity to error template. Bug 18387: (QA Follow up) adding specificity to error template. Bug 18387: Allow sco-user to access errors templates Bug 18387: (QA Follow up) adding specificity to error template. |
Description
Nick Clemens (kidclamp)
2017-04-05 12:15:25 UTC
Looks like a 304 and others can trigger this as well Hi! We're experiencing this too in one of our Koha installation, 16.11.05. I would not consider this as a bug, you hyst need to fix the url ...right? I would not consider this as a bug, you just need to fix the url ...right? (In reply to Jonathan Druart from comment #4) > I would not consider this as a bug, you just need to fix the url ...right? Technically yes, but no visible error is thrown to the user, you are just silently signed out. Why fetch the 404 error template if we aren't displaying it? Created attachment 76797 [details] [review] Bug 18387: Allow sco-user to access errors templates To test: 1 - Enable AuthoSelfCheck prefs 2 - In opacuserjs or scouserjs add a fetch of an unreachable resources 3 - Visit the SCO 4 - Sign in as a patron then click 'finish' 5 - Say 'yes' to receipt 6 - Note you are directed to log in 7 - Apply patch 8 - Restart all the things 9 - Repeat 4 & 5 10 - Sucess, receipt prints Nick, please don't forget to set the assignee on your bugs! It looks like we can be more precise and use the full path: errors/errorpage.tt This definitely makes the slip show and be printable, but can someone else confirm this weird behaviour I'm seeing, where the SCO slip comes out as uninterpreted HTML instead of nicely formatted? Also the behaviour seems to manifest on master right now with or without an asset going 404. It's all very perplexing. Should add that I was seeing this both with and without Jonathan's proposed modification. Liz Created attachment 87420 [details] [review] Bug 18387: Allow sco-user to access errors templates To test: 1 - Enable AuthoSelfCheck prefs 2 - In opacuserjs or scouserjs add a fetch of an unreachable resources 3 - Visit the SCO 4 - Sign in as a patron then click 'finish' 5 - Say 'yes' to receipt 6 - Note you are directed to log in 7 - Apply patch 8 - Restart all the things 9 - Repeat 4 & 5 10 - Sucess, receipt prints Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 87421 [details] [review] Bug 18387: (QA Follow up) adding specificity to error template. Per Jonathan's comment. Comment on attachment 87421 [details] [review] Bug 18387: (QA Follow up) adding specificity to error template. Review of attachment 87421 [details] [review]: ----------------------------------------------------------------- ::: C4/Auth.pm @@ +192,5 @@ > if ( > # If the user logged in is the SCO user and they try to go out of the SCO module, > # log the user out removing the CGISESSID cookie > + $in->{template_name} !~ m|sco/| && $in->{template_name} !~ m|errors/errorpage.tt| > + &r C4::Context->preference('AutoSelfCheckID') Looks like a typo here.. `&r` ? Created attachment 87657 [details] [review] Bug 18387: (QA Follow up) adding specificity to error template. (sorry) No worries, I initially thought it was a new perl operator I hadn't come across. I'll do some testing proper tomorrow morning. Thanks Liz Created attachment 87845 [details] [review] Bug 18387: Allow sco-user to access errors templates To test: 1 - Enable AuthoSelfCheck prefs 2 - In opacuserjs or scouserjs add a fetch of an unreachable resources 3 - Visit the SCO 4 - Sign in as a patron then click 'finish' 5 - Say 'yes' to receipt 6 - Note you are directed to log in 7 - Apply patch 8 - Restart all the things 9 - Repeat 4 & 5 10 - Sucess, receipt prints Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 87846 [details] [review] Bug 18387: (QA Follow up) adding specificity to error template. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 18.05.x is currently missing 22641 dependency, im not backporting this to 18.05.x series |