| Summary: | Add an option to item search to export a barcodes file | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
| Component: | Searching | Assignee: | Julian Maurice <julian.maurice> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, kyle, stephane.delaye |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 18433 | ||
| Attachments: |
Bug 18394: Remove useless code from item search
Bug 18394: Add an option to item search to export a barcodes file [SIGNED-OFF] Bug 18394: Remove useless code from item search [SIGNED-OFF] Bug 18394: Add an option to item search to export a barcodes file Bug 18394: Remove useless code from item search Bug 18394: Add an option to item search to export a barcodes file |
||
|
Description
Julian Maurice
2017-04-06 15:25:32 UTC
Created attachment 61937 [details] [review] Bug 18394: Remove useless code from item search The item search was originally designed to work even with JS disabled. Since bug 15111, the staff interface does not work at all without JS, so some parts of this code are useless and should be removed Created attachment 61938 [details] [review] Bug 18394: Add an option to item search to export a barcodes file Test plan: 1. Go to item search (/cgi-bin/koha/catalogue/itemsearch.pl) 2. Fill the form with whatever you want 3. Leave the 'Output' option to 'Screen' and click 'Search' 4. Verify that the search still works 5. Click on 'Edit search' and set 'Output' to 'Barcodes file', click 'Search' 6. You should be able to download a 'barcodes.txt' file, open it and compare it to the previous search results 7. Now click on the 'Export results to barcodes file' button above the results, you should have the same result as in step 5 8. Verify that the CSV export still works Step 5 and Step 7 don't work for me. I expect the browser to start the download of a text file, but the page reloads without any prompt. Hi Owen, do you have any JS errors in the console ? Sorry, it must have been a problem with my setup. It looks like it's working now. I'll continue testing. Created attachment 62006 [details] [review] [SIGNED-OFF] Bug 18394: Remove useless code from item search The item search was originally designed to work even with JS disabled. Since bug 15111, the staff interface does not work at all without JS, so some parts of this code are useless and should be removed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 62007 [details] [review] [SIGNED-OFF] Bug 18394: Add an option to item search to export a barcodes file Test plan: 1. Go to item search (/cgi-bin/koha/catalogue/itemsearch.pl) 2. Fill the form with whatever you want 3. Leave the 'Output' option to 'Screen' and click 'Search' 4. Verify that the search still works 5. Click on 'Edit search' and set 'Output' to 'Barcodes file', click 'Search' 6. You should be able to download a 'barcodes.txt' file, open it and compare it to the previous search results 7. Now click on the 'Export results to barcodes file' button above the results, you should have the same result as in step 5 8. Verify that the CSV export still works Signed-off-by: Owen Leonard <oleonard@myacpl.org> The number of exported barcodes remains unchanged despite the use of filters in the result table (In reply to delaye from comment #8) > The number of exported barcodes remains unchanged despite the use of filters > in the result table Yes right, but this behavior already existed when exporting as CSV. Julian, any chances to see you fix that on another bug report? :) Passing QA this one. Created attachment 62068 [details] [review] Bug 18394: Remove useless code from item search The item search was originally designed to work even with JS disabled. Since bug 15111, the staff interface does not work at all without JS, so some parts of this code are useless and should be removed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 62069 [details] [review] Bug 18394: Add an option to item search to export a barcodes file Test plan: 1. Go to item search (/cgi-bin/koha/catalogue/itemsearch.pl) 2. Fill the form with whatever you want 3. Leave the 'Output' option to 'Screen' and click 'Search' 4. Verify that the search still works 5. Click on 'Edit search' and set 'Output' to 'Barcodes file', click 'Search' 6. You should be able to download a 'barcodes.txt' file, open it and compare it to the previous search results 7. Now click on the 'Export results to barcodes file' button above the results, you should have the same result as in step 5 8. Verify that the CSV export still works Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Jonathan Druart from comment #9) > (In reply to delaye from comment #8) > > The number of exported barcodes remains unchanged despite the use of filters > > in the result table > > Yes right, but this behavior already existed when exporting as CSV. > > Julian, any chances to see you fix that on another bug report? :) > > Passing QA this one. Thanks. That's probably what I'll do Pushed to master for 17.05, thanks Julian! This won't get ported back to 16.11.x as it is an enhancement. |