Summary: | Audio alerts: Add a hint that the upload file tool can be used for adding custom sound files | ||
---|---|---|---|
Product: | Koha | Reporter: | Cab Vinton <bibliwho> |
Component: | Staff interface | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, gmcharlt, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27598 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 18146: Fix tests for OverduesBlockRenewing
Bug 18416: (follow-up) Remove warn for uninitialized value |
Description
Cab Vinton
2017-04-11 15:24:26 UTC
Created attachment 116038 [details] [review] Bug 18146: Fix tests for OverduesBlockRenewing This pref was supposedly covered by tests, but the conditions were wrong and we didn't test the reasons we were failing so the code was being missed To test: 1 - Add a warn around in the conditional at line 2748: } elsif ( ($hasoverdues and $overduesblockrenewing eq 'block') || ($itemissue->{overdue} and $overduesblockrenewing eq 'blockitem') ) { warn "SUCCESS!" return ( 0, 'overdue'); } 2 - prove -v t/db_dependent/Circulation.t | grep SUCCESS 3 - No output 4 - Apply patch 5 - Repeat 6 - SUCCESS! Created attachment 116039 [details] [review] Bug 18416: (follow-up) Remove warn for uninitialized value In the previous patch you may have noticed many warns when running the tests We add guarantor charges to a variable to determine if over the limit, but we don't initialize that value We should To test: 1 - Apply first patch and follow test plan 2 - Note warns when proving test 3 - Apply this patch 4 - prove 5 - No more warns Patches on wrong bug, but also, one can point to custom sounds, or upload files using the koha upload tool and use those *** This bug has been marked as a duplicate of bug 11431 *** I think in the upload tools it's totally not obvious that this will work. I think it would be nice to have this more integrated allowing the upload directly from this page or by adding a hint with a link. Reopening with a changed description :) (In reply to Cab Vinton from comment #0) > Think of the possibilities -- Warnings in Darth Vader's voice. Reminders in > a soothing British accent. Etc. > https://www.youtube.com/watch?v=97b6FfQbibM Is it possible to access an uploaded file via a URL? (In reply to Owen Leonard from comment #6) > Is it possible to access an uploaded file via a URL? Yes but only if it has been made publicly-accessible: Bug 27594 |