Bug 18427

Summary: Add a primary key to serialitems
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer, kyle
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361
Change sponsored?: --- Patch complexity: ---
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 18182    
Attachments: Bug 18427: Add a primary key to serialitems
Bug 18427: DBIx schema changes
Bug 18427: DBIx schema changes
Bug 18427: Add a primary key to serialitems
Bug 18427: DBIx schema changes
Bug 18427: Add a primary key to serialitems
Bug 18427: DBIx schema changes
Bug 18427: Add a primary key to serialitems

Description Marcel de Rooy 2017-04-13 10:24:46 UTC
See bug 18361
Comment 1 Marcel de Rooy 2017-04-13 11:55:15 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2017-04-13 11:55:19 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2017-04-13 12:03:35 UTC
Created attachment 62146 [details] [review]
Bug 18427: DBIx schema changes

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2017-04-13 12:03:38 UTC
Created attachment 62147 [details] [review]
Bug 18427: Add a primary key to serialitems

We drop the unique index serialitemsidx and add a primary key consisting
of itemnumber just as the unique key did.

Test plan:
Run the db revision.
Apply bug 18182. The TestBuilder.t should no longer fail on serialitems.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi 2017-04-19 13:40:19 UTC
Created attachment 62365 [details] [review]
Bug 18427: DBIx schema changes

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Tomás Cohen Arazi 2017-04-19 13:40:26 UTC
Created attachment 62366 [details] [review]
Bug 18427: Add a primary key to serialitems

We drop the unique index serialitemsidx and add a primary key consisting
of itemnumber just as the unique key did.

Test plan:
Run the db revision.
Apply bug 18182. The TestBuilder.t should no longer fail on serialitems.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 7 Jonathan Druart 2017-04-19 14:45:52 UTC
Created attachment 62381 [details] [review]
Bug 18427: DBIx schema changes

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2017-04-19 14:45:57 UTC
Created attachment 62382 [details] [review]
Bug 18427: Add a primary key to serialitems

We drop the unique index serialitemsidx and add a primary key consisting
of itemnumber just as the unique key did.

Test plan:
Run the db revision.
Apply bug 18182. The TestBuilder.t should no longer fail on serialitems.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Marcel de Rooy 2017-04-19 14:47:50 UTC
Thx Tomas, Jonathan
Comment 10 Kyle M Hall 2017-04-21 18:09:20 UTC
Pushed to master for 17.05, thanks Marcel!
Comment 11 Katrin Fischer 2017-04-21 23:17:17 UTC
This won't get ported back to 16.11.x as it is an enhancement.