Summary: | Add a primary key to serialitems | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 18182 | ||
Attachments: |
Bug 18427: Add a primary key to serialitems
Bug 18427: DBIx schema changes Bug 18427: DBIx schema changes Bug 18427: Add a primary key to serialitems Bug 18427: DBIx schema changes Bug 18427: Add a primary key to serialitems Bug 18427: DBIx schema changes Bug 18427: Add a primary key to serialitems |
Description
Marcel de Rooy
2017-04-13 10:24:46 UTC
Created attachment 62144 [details] [review] Bug 18427: Add a primary key to serialitems We drop the unique index serialitemsidx and add a primary key consisting of itemnumber just as the unique key did. Test plan: Run the db revision. Apply bug 18182. The TestBuilder.t should no longer fail on serialitems. Created attachment 62145 [details] [review] Bug 18427: DBIx schema changes Created attachment 62146 [details] [review] Bug 18427: DBIx schema changes Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 62147 [details] [review] Bug 18427: Add a primary key to serialitems We drop the unique index serialitemsidx and add a primary key consisting of itemnumber just as the unique key did. Test plan: Run the db revision. Apply bug 18182. The TestBuilder.t should no longer fail on serialitems. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 62365 [details] [review] Bug 18427: DBIx schema changes Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 62366 [details] [review] Bug 18427: Add a primary key to serialitems We drop the unique index serialitemsidx and add a primary key consisting of itemnumber just as the unique key did. Test plan: Run the db revision. Apply bug 18182. The TestBuilder.t should no longer fail on serialitems. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 62381 [details] [review] Bug 18427: DBIx schema changes Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 62382 [details] [review] Bug 18427: Add a primary key to serialitems We drop the unique index serialitemsidx and add a primary key consisting of itemnumber just as the unique key did. Test plan: Run the db revision. Apply bug 18182. The TestBuilder.t should no longer fail on serialitems. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Thx Tomas, Jonathan Pushed to master for 17.05, thanks Marcel! This won't get ported back to 16.11.x as it is an enhancement. |