| Summary: | Receiving an item should update the datelastseen | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | julian.maurice, kyle, m.de.rooy, mtj, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 18429 - Receiving an item should update the datelastseen
Bug 18429 - Receiving an item should update the datelastseen [SIGNED OFF] Bug 18429 - Receiving an item should update the datelastseen Bug 18429 - Receiving an item should update the datelastseen |
||
|
Description
Nick Clemens (kidclamp)
2017-04-13 13:54:30 UTC
Created attachment 62148 [details] [review] Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. Created attachment 62153 [details] [review] Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 62154 [details] [review] [SIGNED OFF] Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Works as expected. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Shouldn't it be today instead of date received ? Hmm.. Date received defaults to today - I would say if you are changing that (receiving on past days) you might not physically have the item in hand so are confirming you saw it last on the day you received it? I would think it should be this way, but am open to changing it Created attachment 62360 [details] [review] Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Works as expected. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Nick Clemens from comment #5) > Hmm.. > > Date received defaults to today - I would say if you are changing that > (receiving on past days) you might not physically have the item in hand so > are confirming you saw it last on the day you received it? > > I would think it should be this way, but am open to changing it Sounds reasonable enough. Pushed to master for 17.05, thanks Nick! This patch has been pushed to 16.11.x and will be in 16.11.07. Pushed to 16.05.x, for 16.05.12 release Pushed to 3.22.x for 3.22.21 |