Summary: | Resend button for notices being hidden by CSS and never unhidden | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Notices | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | jonathan.druart, julian.maurice, kyle, lari.taskula, mtj, nick, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 11274, 12426 | ||
Bug Blocks: | 36810 | ||
Attachments: |
Bug 18439 - Resend button for notices being hidden by CSS and never unhidden
Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Bug 18439 - Resend button for notices being hidden by CSS and never unhidden |
Description
Nick Clemens (kidclamp)
2017-04-17 17:12:37 UTC
Created attachment 62226 [details] [review] Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Current jQuery is not unhiding resend button, this patch adds an id and a toggle command To test: 1 - Enable EnhancedMessagingPreferences 2 - Find a patron with sent or failed messages 3 - Note you can expand message, but not resend 4 - Apply patch 5 - Note that on expanding message a 'Resend' button appears 6 - Ensure resend button operates as expected Created attachment 62227 [details] [review] Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Current jQuery is not unhiding resend button, this patch adds an id and a toggle command To test: 1 - Enable EnhancedMessagingPreferences 2 - Find a patron with sent or failed messages 3 - Note you can expand message, but not resend 4 - Apply patch 5 - Note that on expanding message a 'Resend' button appears 6 - Ensure resend button operates as expected Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 62265 [details] [review] Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Current jQuery is not unhiding resend button, this patch adds an id and a toggle command To test: 1 - Enable EnhancedMessagingPreferences 2 - Find a patron with sent or failed messages 3 - Note you can expand message, but not resend 4 - Apply patch 5 - Note that on expanding message a 'Resend' button appears 6 - Ensure resend button operates as expected Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Lari Taskula <lari.taskula@jns.fi> Created attachment 62317 [details] [review] Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Current jQuery is not unhiding resend button, this patch adds an id and a toggle command To test: 1 - Enable EnhancedMessagingPreferences 2 - Find a patron with sent or failed messages 3 - Note you can expand message, but not resend 4 - Apply patch 5 - Note that on expanding message a 'Resend' button appears 6 - Ensure resend button operates as expected Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Lari Taskula <lari.taskula@jns.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Nick! This patch has been pushed to 16.11.x and will be in 16.11.07. Pushed to 16.05.x, for 16.05.12 release Pushed to 3.22.x for 3.22.21 (In reply to Julian Maurice from comment #9) > Pushed to 3.22.x for 3.22.21 Wrong bug, sorry. This patch is not needed in 3.22.x |