Description
Nick Clemens (kidclamp)
2017-04-21 01:36:32 UTC
Created attachment 62512 [details] [review] Bug 18468 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices To test: 1 - Setup a vendor with a discount 2 - Stage a file 3 - Create a basket 4 - Order from staged file 5 - Add a price but no discount 6 - Save order 7 - Note ecost is not discounted 8 - Apply patch 9 - Repeate 2-6 10 - Note ecost is discounted Created attachment 62578 [details] [review] Bug 18468 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices To test: 1 - Setup a vendor with a discount 2 - Stage a file 3 - Create a basket 4 - Order from staged file 5 - Add a price but no discount 6 - Save order 7 - Note ecost is not discounted 8 - Apply patch 9 - Repeate 2-6 10 - Note ecost is discounted Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Created attachment 62618 [details] [review] Bug 18468 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices To test: 1 - Setup a vendor with a discount 2 - Stage a file 3 - Create a basket 4 - Order from staged file 5 - Add a price but no discount 6 - Save order 7 - Note ecost is not discounted 8 - Apply patch 9 - Repeate 2-6 10 - Note ecost is discounted Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Nick! Hello, I'm into testing Koha 16.11.06 and i noticed the same problem. Can this patch be backported to 16.11 or shall I open a new bug ? Thanx. (In reply to jmbroust from comment #5) > Hello, I'm into testing Koha 16.11.06 and i noticed the same problem. Can > this patch be backported to 16.11 or shall I open a new bug ? Thanx. Ccing Katrin, Rmaint 16.11. Dependency is not in 16.11.x. Just noticed the earlier comments - checking. The patch from master doesn't apply cleanly on 16.11.x and I am not sure how to resolve the conflict. Can someone take a look and provide a patch for 16.11.x? The conflict in acqui/addorderiso2709.pl is quite confusing, need some help to resolve that. |