Bug 18477

Summary: AR_PENDING notice does not populate values from article_requests table.
Product: Koha Reporter: Barton Chittenden <barton>
Component: NoticesAssignee: Kyle M Hall <kyle>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: ephetteplace, jonathan.druart, kyle, nick
Version: master   
Hardware: All   
OS: All   
Whiteboard:
Change sponsored?: --- Patch complexity: Trivial patch
Bot Control: --- When did the bot last check this:
Who signed the patch off: Text to go in the release notes:
Attachments: Bug 18477 - AR_PENDING notice does not populate values from article_requests table
Bug 18477 - AR_PENDING notice does not populate values from article_requests table

Description Barton Chittenden 2017-04-21 16:27:55 UTC
The default AR_PENDING letter does not print populate <<article_requests.*>> fields.

To replicate:

1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes )
2) Search for a title, click in to catalog detail, click 'Request Article' button.
3) Select Patron
4) Fill out request information
5) Click 'Pplace request'
6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display.

Examples below:

AR_PENDING

===================================
<<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)

We have received your request for an article from <<biblio.title>>.

Article requested:
Title: <<article_requests.title>>
Author: <<article_requests.author>>
Volume: <<article_requests.volume>>
Issue: <<article_requests.issue>>
Date: <<article_requests.date>>
Pages: <<article_requests.pages>>
Chapters: <<article_requests.chapters>>
Notes: <<article_requests.patron_notes>>
===================================


Displays as

===================================
Barton Chittenden (barton)

We have received your request for an article from Bws test record 2 ().

Article requested:
Title: 
Author: 
Volume: 
Issue: 
Date: 
Pages: 
Chapters: 
Notes: 


Thank you!
===================================


The 'processing' and 'completed' notices work work, here's the output from 'Article Request Completed'

===================================
Barton Chittenden (barton)

We are have completed your request for an article from Bws test record 2 ().

Article requested:
Title: TEST TEST TEST
Author: asdfsadf
Volume: foo
Issue: bar
Date: baz
Pages: 123234
Chapters: 9
Notes: Raaaaaagh!

You may pick your article up at Midway.

Thank you!
===================================
Comment 1 Kyle M Hall 2017-05-08 16:49:26 UTC
Created attachment 63251 [details] [review]
Bug 18477 - AR_PENDING notice does not populate values from article_requests table

The default AR_PENDING letter does not print populate <<article_requests.*>> fields.

Test Plan:
1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes )
2) Search for a title, click in to catalog detail, click 'Request Article' button.
3) Select Patron
4) Fill out request information
5) Click 'Place request'
6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display.
7) Apply this patch
8) Repeat steps 2-6, not the fields now display!
Comment 2 Eric Phetteplace 2017-05-08 22:41:46 UTC
Created attachment 63261 [details] [review]
Bug 18477 - AR_PENDING notice does not populate values from article_requests table

The default AR_PENDING letter does not print populate <<article_requests.*>> fields.

Test Plan:
1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes )
2) Search for a title, click in to catalog detail, click 'Request Article' button.
3) Select Patron
4) Fill out request information
5) Click 'Place request'
6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display.
7) Apply this patch
8) Repeat steps 2-6, not the fields now display!

Signed-off-by: Eric Phetteplace <phette23@gmail.com>
Comment 3 Jonathan Druart 2017-05-11 15:50:30 UTC
Please provide tests!