Summary: | Holds 'Placed on' column in opac-user.pl not sorting correctly | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly
[SIGNED-OFF] Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly |
Description
Nick Clemens (kidclamp)
2017-04-21 19:02:19 UTC
Created attachment 62590 [details] [review] Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly Two columns in the user's holds table in the OPAC do not sort correctly because they are not marked up correctly to enable date sorting: 'Placed on' and 'Expires on.' This patch corrects it. This patch also removes a stray </td> which was causing validation errors. To test, apply the patch and log into the OPAC with an account which has multiple holds with differnt hold dates and expiration dates. Confirm that sorting on these columns works correctly. Created attachment 62728 [details] [review] [SIGNED-OFF] Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly Two columns in the user's holds table in the OPAC do not sort correctly because they are not marked up correctly to enable date sorting: 'Placed on' and 'Expires on.' This patch corrects it. This patch also removes a stray </td> which was causing validation errors. To test, apply the patch and log into the OPAC with an account which has multiple holds with differnt hold dates and expiration dates. Confirm that sorting on these columns works correctly. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 62731 [details] [review] Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly Two columns in the user's holds table in the OPAC do not sort correctly because they are not marked up correctly to enable date sorting: 'Placed on' and 'Expires on.' This patch corrects it. This patch also removes a stray </td> which was causing validation errors. To test, apply the patch and log into the OPAC with an account which has multiple holds with differnt hold dates and expiration dates. Confirm that sorting on these columns works correctly. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 17.05, thanks Owen! Patch doesn't apply cleanly to 16.11.x - please rebase! 2 months, no rebase. Closing. |