|
Description
Marc Véron
2017-04-21 20:31:08 UTC
Created attachment 62562 [details] [review] Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner To reproduce: - Go to Home > Administration > Budgets > Funds > Modify fund ... - Click "Select owner" - In pop up window, search for patrons In the result list, the patron's name etc. is linked to the patron's detail page. If you accidentally click on the link, their detail screen is displayed inside the pop up. No way to get back to the selection screen. (You have to close the pop up and start over adding.) To test: - Apply patch, restart memcached and plack - Repeat steps above, verify that the patron's name is no longer linked - Verify that no other windows are affected where the link is necessary or useful Created attachment 75461 [details] [review] Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients I'm proposing an alternate solution which affects not just the patron search for fund owner but other similar pop-up searches too. In my version the patron link triggers a modal windows with more patron details. This eliminates the unwanted redirection while still allowing the user to get more information. Created attachment 77743 [details] [review] Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients Created attachment 78395 [details] [review] Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients When I try to apply the patch, it's giving me a conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt Created attachment 78925 [details] [review] Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner To reproduce: - Go to Home > Administration > Budgets > Funds > Modify fund ... - Click "Select owner" - In pop up window, search for patrons In the result list, the patron's name etc. is linked to the patron's detail page. If you accidentally click on the link, their detail screen is displayed inside the pop up. No way to get back to the selection screen. (You have to close the pop up and start over adding.) To test: - Apply patch, restart memcached and plack - Repeat steps above, verify that the patron's name is no longer linked - Verify that no other windows are affected where the link is necessary or useful Created attachment 78926 [details] [review] Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients Some comments : 1) If I click to view a patron, close the modal, and click to view another one, the information takes a second to change from the previous patron to the new patron. I don't know if this has to do with plack or memcached, I don't know how to reset those. 2) Would it be possible to add a "Select" or "Add" button in the modal, so that if we view the patron info and decide this is the patron we want, we don't have to close the modal, then look for the patron in the list and click add Created attachment 79004 [details] [review] Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients (In reply to Caroline Cyr La Rose from comment #9) > Some comments : > > 1) If I click to view a patron, close the modal, and click to view another > one, the information takes a second to change from the previous patron to > the new patron. This should now be fixed. > 2) Would it be possible to add a "Select" or "Add" button in the modal I think this is a good idea, but I would prefer to make that change in a separate bug if that's acceptable. After searching a patron, link to patron account on page '/cgi-bin/koha/members/members-home.pl' is broken when the patch is applied. Created attachment 79899 [details] [review] Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients Created attachment 79943 [details] [review] Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> All the different strange behaviours we had before (comments 9 & 12) seem fixed. Should we adjust the bug title to something more positive? The new modal seems like a nice improvement over the previous behavior and no link was actually removed. Created attachment 80168 [details] [review] Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05.x series. |