Bug 18480

Summary: Use modal for displaying patron details on add_user_search.pl to avoid redirect
Product: Koha Reporter: Marc Véron <veron>
Component: AcquisitionsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, katrin.fischer, martin.renvoize, nick, severine.queune
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner

Description Marc Véron 2017-04-21 20:31:08 UTC
To reproduce: 

- Go to Home > Administration > Budgets > Funds > Modify fund ...
- Click "Select owner"
- In pop up window, search for patrons
In the result list, the patron's name etc. is linked to the patron's detail
page. If you accidentally click on the link, their detail screen is displayed inside the pop up. No way to get back to the selection screen. (You have to close the pop up and start over adding.)
Comment 1 Marc Véron 2017-04-21 20:37:16 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2018-05-21 16:30:41 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2018-05-21 16:32:20 UTC
I'm proposing an alternate solution which affects not just the patron search for fund owner but other similar pop-up searches too. In my version the patron link triggers a modal windows with more patron details. This eliminates the unwanted redirection while still allowing the user to get more information.
Comment 4 Owen Leonard 2018-08-13 14:01:30 UTC Comment hidden (obsolete)
Comment 5 Owen Leonard 2018-09-04 13:18:06 UTC Comment hidden (obsolete)
Comment 6 Caroline Cyr La Rose 2018-09-15 22:36:19 UTC
When I try to apply the patch, it's giving me a conflict in 
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt
Comment 7 Chris Cormack 2018-09-16 16:25:30 UTC Comment hidden (obsolete)
Comment 8 Chris Cormack 2018-09-16 16:25:33 UTC Comment hidden (obsolete)
Comment 9 Caroline Cyr La Rose 2018-09-16 16:47:00 UTC
Some comments :

 1) If I click to view a patron, close the modal, and click to view another one, the information takes a second to change from the previous patron to the new patron. I don't know if this has to do with plack or memcached, I don't know how to reset those.

 2) Would it be possible to add a "Select" or "Add" button in the modal, so that if we view the patron info and decide this is the patron we want, we don't have to close the modal, then look for the patron in the list and click add
Comment 10 Owen Leonard 2018-09-16 21:07:17 UTC
Created attachment 79004 [details] [review]
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner

This patch modifies templates where a pop-up window is used to display
patron search results. A link has been added to the patron name which
triggers a modal window displaying more details about that patron. With
each page in the test plan, check that clicking linked names in search
results triggers a modal with the correct data.

 - Acquisitions -> Vendor -> View basket -> Add user
 - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record
   -> Add user
 - Acquisitions -> Funds -> Edit fund -> Select owner
 - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add
   patrons
 - Serials -> Subscription -> Edit routing list -> Add recipients
Comment 11 Owen Leonard 2018-09-16 21:08:53 UTC
(In reply to Caroline Cyr La Rose from comment #9)
> Some comments :
> 
>  1) If I click to view a patron, close the modal, and click to view another
> one, the information takes a second to change from the previous patron to
> the new patron. 

This should now be fixed.

>  2) Would it be possible to add a "Select" or "Add" button in the modal

I think this is a good idea, but I would prefer to make that change in a separate bug if that's acceptable.
Comment 12 Séverine Queune 2018-09-16 23:11:18 UTC
After searching a patron, link to patron account on page '/cgi-bin/koha/members/members-home.pl' is broken when the patch is applied.
Comment 13 Owen Leonard 2018-10-03 15:22:35 UTC
Created attachment 79899 [details] [review]
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner

This patch modifies templates where a pop-up window is used to display
patron search results. A link has been added to the patron name which
triggers a modal window displaying more details about that patron. With
each page in the test plan, check that clicking linked names in search
results triggers a modal with the correct data.

 - Acquisitions -> Vendor -> View basket -> Add user
 - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record
   -> Add user
 - Acquisitions -> Funds -> Edit fund -> Select owner
 - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add
   patrons
 - Serials -> Subscription -> Edit routing list -> Add recipients
Comment 14 Séverine Queune 2018-10-04 11:33:52 UTC
Created attachment 79943 [details] [review]
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner

This patch modifies templates where a pop-up window is used to display
patron search results. A link has been added to the patron name which
triggers a modal window displaying more details about that patron. With
each page in the test plan, check that clicking linked names in search
results triggers a modal with the correct data.

 - Acquisitions -> Vendor -> View basket -> Add user
 - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record
   -> Add user
 - Acquisitions -> Funds -> Edit fund -> Select owner
 - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add
   patrons
 - Serials -> Subscription -> Edit routing list -> Add recipients

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 15 Séverine Queune 2018-10-04 11:36:21 UTC
All the different strange behaviours we had before (comments 9 & 12) seem fixed.
Comment 16 Katrin Fischer 2018-10-06 20:28:39 UTC
Should we adjust the bug title to something more positive? The new modal seems like a nice improvement over the previous behavior and no link was actually removed.
Comment 17 Katrin Fischer 2018-10-06 20:31:24 UTC
Created attachment 80168 [details] [review]
Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner

This patch modifies templates where a pop-up window is used to display
patron search results. A link has been added to the patron name which
triggers a modal window displaying more details about that patron. With
each page in the test plan, check that clicking linked names in search
results triggers a modal with the correct data.

 - Acquisitions -> Vendor -> View basket -> Add user
 - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record
   -> Add user
 - Acquisitions -> Funds -> Edit fund -> Select owner
 - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add
   patrons
 - Serials -> Subscription -> Edit routing list -> Add recipients

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 18 Nick Clemens 2018-10-15 16:57:24 UTC
Awesome work all!

Pushed to master for 18.11
Comment 19 Martin Renvoize 2018-10-17 11:04:16 UTC
Enhancement, will not be backported to 18.05.x series.