| Summary: | moremember.pl template param without key | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lari Taskula <lari.taskula> |
| Component: | Staff interface | Assignee: | Lari Taskula <lari.taskula> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | gmcharlt, jonathan.druart |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 18492: moremember.pl template param without key
[SIGNED-OFF] Bug 18492: moremember.pl template param without key |
||
|
Description
Lari Taskula
2017-04-25 12:11:48 UTC
Created attachment 62660 [details] [review] Bug 18492: moremember.pl template param without key moremember.pl has a template parameter without a key bug after Bug 5670. I noticed this when working with Relatives checkouts tab, which was oddly missing even though the guarantee had checkouts. Also I get this warning in my logs: Problem = a value of activeBorrowerRelationship has been passed to param without key at /home/koha/kohaclone/C4/Templates.pm line 137. The issue is at the end of moremember.pl, in $template->param( ... housebound_role => $patron->housebound_role, ... ); $patron->housebound_role seems to return an empty list instead of undef in scalar context. To replicate: 1. Ensure patron is not associated with a HouseboundRole 2. Go to patron's details tab 3. See your error log, it should have a warning "Problem = a value of activeBorrowerRelationship has been passed to param without key" To test: 1. Apply patch 2. Perform the steps at "To replicate" plan 3. Observe there are no longer warnings Increasing importance of Bug as I cannot see relatives' checkouts tab without this patch. Created attachment 62665 [details] [review] [SIGNED-OFF] Bug 18492: moremember.pl template param without key moremember.pl has a template parameter without a key bug after Bug 5670. I noticed this when working with Relatives checkouts tab, which was oddly missing even though the guarantee had checkouts. Also I get this warning in my logs: Problem = a value of activeBorrowerRelationship has been passed to param without key at /home/koha/kohaclone/C4/Templates.pm line 137. The issue is at the end of moremember.pl, in $template->param( ... housebound_role => $patron->housebound_role, ... ); $patron->housebound_role seems to return an empty list instead of undef in scalar context. To replicate: 1. Ensure patron is not associated with a HouseboundRole 2. Go to patron's details tab 3. See your error log, it should have a warning "Problem = a value of activeBorrowerRelationship has been passed to param without key" To test: 1. Apply patch 2. Perform the steps at "To replicate" plan 3. Observe there are no longer warnings Signed-off-by: Owen Leonard <oleonard@myacpl.org> |