Description
Chris Cormack
2017-04-30 23:59:04 UTC
Created attachment 62902 [details] [review] Bug 18514 : Script to fetch records from Overdrive To Test: You must be running Elasticsearch with Koha 1/ Fill in the Overdrive system preferences 2/ run this script 3/ Records should be in ElasticSearch Created attachment 62903 [details] [review] Bug 18514 : Adding search capabilities for Overdrive results in Koha To test 1/ Apply the first patch and run the script in it 2/ Search, notice no Overdrive results showing 3/ Search again, now you should get results in the OPAC results page Created attachment 62904 [details] [review] Bug 18514 Fix link on results page, and show overdrive data on detail page To test 1/ Apply the first 2 patches, and run the fetcher script (in patch one) 2/ Search, notice the overdrive results result in a 404 if you click on them 3/ Apply this patch 4/ Search again 5/ Click on a result, you should now be at a detail page I think there are some updates on a git branch that need to be imported here, current code doesn't run Actually no there aren't. Have you not been seeing my updates in our WR system Nick? Basically there isn't missing code here, rebuilding elastic search indexes is busted in master. [Request] ** http://localhost:9200 -[400] [mapper_parsing_exception] Failed to parse mapping [data]: The [string] type is removed in 5.0 and automatic upgrade failed because parameters [index_analyzer] are not supported for automatic upgrades. You should now use either a [text] or [keyword] field instead for field [ff7-01-02] This is nothing to do with the overdrive code. As it dies for misc/search_tools/rebuild_elastic_search.pl too. Which is not touched by this. That dies for me on current master, with or without these patches. (As an aside we need to track down why you didnt see the updates) I will double check, I may have just missed those and jumped here. A few lines do need fixed though: Koha::ElasticSearch::Indexer; should be Koha::SearchEngine::Elasticsearch::Indexer; Do you have a bug for ES indexing broken? I haven't hit a problem, but maybe I need to refresh my mappings. -Nick Created attachment 65004 [details] [review] Bug 18514 - Followup Adjust ES paths Alter fix to retain ID (so records overwrite on re-run) Commit the records With a few minor adjustments things are working and records get indexed. Created attachment 65858 [details] [review] Bug 18514 - Followup Adjust ES paths Alter fix to retain ID (so records overwrite on re-run) Commit the records Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 65859 [details] [review] Bug 18514 : Script to fetch records from Overdrive To Test: You must be running Elasticsearch with Koha 1/ Fill in the Overdrive system preferences 2/ run this script 3/ Records should be in ElasticSearch Created attachment 65860 [details] [review] Bug 18514 : Adding search capabilities for Overdrive results in Koha To test 1/ Apply the first patch and run the script in it 2/ Search, notice no Overdrive results showing 3/ Search again, now you should get results in the OPAC results page Created attachment 65861 [details] [review] Bug 18514 Fix link on results page, and show overdrive data on detail page To test 1/ Apply the first 2 patches, and run the fetcher script (in patch one) 2/ Search, notice the overdrive results result in a 404 if you click on them 3/ Apply this patch 4/ Search again 5/ Click on a result, you should now be at a detail page If you do get a chance to rebase this. Please ping me I'd be really happy to test it immediately so we don't have to go through another rebase :) The code does look pretty cool though. |