Summary: | Add ability to skip irrelevant dates in Koha::Calendar | ||
---|---|---|---|
Product: | Koha | Reporter: | Barton Chittenden <barton> |
Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | emma.perks, jonathan.druart, kyle, martin.renvoize, mtj, nick, sally.healey, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 14315 | ||
Attachments: | Bug 18519: Use a hasref for lookup |
Description
Barton Chittenden
2017-05-01 16:56:08 UTC
Well.. we could easily switch from an array which we iterate to a hashref we can to a direct lockup on within the single_holidays method.. that would be a good first step I think. The caveat is that we trade some RAM for performances.. but I don't think it was a deliberate act to choose and array over a hashref in the first place. Created attachment 105843 [details] [review] Bug 18519: Use a hasref for lookup Rather than using an array of dates and iterating them, use a hashref and do a direct lookup So, this made a really significant impact on fines and checkout times on one of our live servers.. The customer in question has added the entirety of Covid Lockdown as special holidays to allow for proper fines calculations for items that went overdue just prior to lockdown. |