| Summary: | Renew and search hotkeys are swapped on returns page. | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tim McMahon <tmcmahon> |
| Component: | Staff interface | Assignee: | Alex Buckley <alexbuckley> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | alexbuckley, fridolin.somers, gmcharlt, martin.renvoize, nick, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 18521 - Moving the if CAN_user_circulate_circulate_remaining_permissions conditional block
Bug 18521 - Moving the if CAN_user_circulate_circulate_remaining_permissions conditional block Bug 18521: Fix key binding in the header |
||
|
Description
Tim McMahon
2017-05-01 19:23:21 UTC
Confirmed. Created attachment 75551 [details] [review] Bug 18521 - Moving the if CAN_user_circulate_circulate_remaining_permissions conditional block Moving the conditional block [% IF (CAN_user_circulate_circulate_remaining_permissions ) %] block up the checkin-search.inc file above the CAN_user_catalogue IF conditional block fixes this bug. Test plan: 1. Go to the circ home page and confirm the following keyboard shortcuts work: Alt+q = goes to search catalog Alt+w = goes to renew 2. Go to returns.pl and confirm the following keyboard shortcuts work: Alt+q = goes to renew Alt+w = goes to search catalog 3. Apply patch 4. Restart apache2, memchached and plack 5. Confirm on the returns.pl the following keyboard shortcuts work: Alt+q = goes to search catalog Alt+w = goes to renew Sponsored-By: Catalyst IT Created attachment 76108 [details] [review] Bug 18521 - Moving the if CAN_user_circulate_circulate_remaining_permissions conditional block Moving the conditional block [% IF (CAN_user_circulate_circulate_remaining_permissions ) %] block up the checkin-search.inc file above the CAN_user_catalogue IF conditional block fixes this bug. Test plan: 1. Go to the circ home page and confirm the following keyboard shortcuts work: Alt+q = goes to search catalog Alt+w = goes to renew 2. Go to returns.pl and confirm the following keyboard shortcuts work: Alt+q = goes to renew Alt+w = goes to search catalog 3. Apply patch 4. Restart apache2, memchached and plack 5. Confirm on the returns.pl the following keyboard shortcuts work: Alt+q = goes to search catalog Alt+w = goes to renew Sponsored-By: Catalyst IT Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. Created attachment 76291 [details] [review] Bug 18521: Fix key binding in the header Moving the conditional block [% IF (CAN_user_circulate_circulate_remaining_permissions ) %] block up the checkin-search.inc file above the CAN_user_catalogue IF conditional block fixes this bug. Test plan: 1. Go to the circ home page and confirm the following keyboard shortcuts work: Alt+q = goes to search catalog Alt+w = goes to renew 2. Go to returns.pl and confirm the following keyboard shortcuts work: Alt+q = goes to renew Alt+w = goes to search catalog 3. Apply patch 4. Restart apache2, memchached and plack 5. Confirm on the returns.pl the following keyboard shortcuts work: Alt+q = goes to search catalog Alt+w = goes to renew Sponsored-By: Catalyst IT Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11.x Pushed to 18.05.x for 18.05.02 Pushed to 17.11.x for 17.11.08 |