Summary: | Unhide the 'Hide window' link in OPAC cart | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 18545 | ||
Bug Blocks: | |||
Attachments: |
Bug 18546 - Unhide the 'Hide window' link in OPAC cart
Bug 18546 - Unhide the 'Hide window' link in OPAC cart Bug 18546 - Unhide the 'Hide window' link in OPAC cart [SIGNED-OFF] Bug 18546 - Unhide the 'Hide window' link in OPAC cart |
Description
Marc Véron
2017-05-05 04:46:19 UTC
It's there, but it's hidden because of a collision with Bootstrap's CSS: <a class="hide close" href="opac-basket.pl">Hide window</a> The "hide" class makes it disappear :( I'm glad someone noticed because I didn't! Created attachment 63777 [details] [review] Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. Note: I did not touch the second toolbar (Select all, Clear all etc.) It has a problem as well: On a small screen, it is hidden (with and without this patch. Maybe the whole cart window needs a rewrite - but that is out of my scope. Setting to NSO. If there is a better solution, I'll be happy to sign off on an alternative patch. The "close" class on that link is what gives it its functionality. There's a globally-defined trigger for "windows.close()" on .close. Otherwise I think this is a good solution. Created attachment 63854 [details] [review] Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. (Amended for comment #5 / 2017-05-30 mv) Created attachment 63884 [details] [review] Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. (Amended for comment #5 / 2017-05-31 mv) Created attachment 63885 [details] [review] [SIGNED-OFF] Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. (Amended for comment #5 / 2017-05-31 mv) Signed-off-by: Owen Leonard <oleonard@myacpl.org> (In reply to Jonathan Druart from comment #9) > Blocked by bug 18545? Bug 18545 is now pushed master, rebase this one ? This solution does no longer work on top of Bug 18545 because the JavaScript is triggered by classes "brief", "detail" etc., and they display the original sprites / icons. As a result, we get two icons if we add the Famfamfam icons. For the original aim of this bug see comment #1 This looks to me to be fixed now. |