Summary: | running koha-create --request-db without an instance name should abort | ||
---|---|---|---|
Product: | Koha | Reporter: | Eric Vantillard <eric.vantillard> |
Component: | Command-line Utilities | Assignee: | Josef Moravec <josef.moravec> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | dilan, jonathan.druart, josef.moravec, kyle, mtj, robin |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | Linux | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 18548: Print usage when missing instance name in koha-create script
Bug 18548: Print usage when missing instance name in koha-create script Screenshot after applying patch - not working Bug 18548: Print usage when missing instance name in koha-create script Bug 18548: Print usage when missing instance name in koha-create script |
Description
Eric Vantillard
2017-05-05 09:47:22 UTC
Created attachment 63159 [details] [review] Bug 18548: Print usage when missing instance name in koha-create script Test plan: 1. Run: debian/scripts/koha-create --request-db -> Without patch you see the getent error message -> With patch you see usage and "Missing instance name" message test done. it's fine. thank you (In reply to Eric Vantillard from comment #2) > test done. it's fine. thank you Please note: "RESOLVED FIXED" status is for bugs pushed to all relevant versions, if you test it and it works for you, you should use "signed off" status. See https://wiki.koha-community.org/wiki/Development_workflow anyway thanks for testing! understood. thanks Josef, Regarding `git grep -i "missing instance" debian/scripts/` I'd suggest to follow the same pattern: [ $# -ge 1 ] || ( usage ; die "Missing instance name..." ) (In reply to Jonathan Druart from comment #5) > Josef, > Regarding `git grep -i "missing instance" debian/scripts/` I'd suggest to > follow the same pattern: > [ $# -ge 1 ] || ( usage ; die "Missing instance name..." ) thanks Jonathan, I'll make new patch... Created attachment 63278 [details] [review] Bug 18548: Print usage when missing instance name in koha-create script Test plan: 1. Run: debian/scripts/koha-create --request-db -> Without patch you see the getent error message -> With patch you see usage and "Missing instance name" message Just tried it Josef. It's still giving a 'getent [...]' message instead. (In reply to dilan from comment #8) > Just tried it Josef. It's still giving a 'getent [...]' message instead. Can't help it, but it works for me... how do you try to test it? On devbox? Created attachment 63319 [details]
Screenshot after applying patch - not working
Yeah on a devbox. Have a look at the attachment. This is the message I get after applying the patch.
(In reply to dilan from comment #10) > Created attachment 63319 [details] > Screenshot after applying patch - not working > > Yeah on a devbox. Have a look at the attachment. This is the message I get > after applying the patch. On devbox you should run it as debian/scripts/koha-create because that's the modified file - the koha-create in system is that one installled by package - so old version Created attachment 63495 [details] [review] Bug 18548: Print usage when missing instance name in koha-create script My apologies Josef, you are correct. It works prefectly with the right command. Signed-off-by: Dilan Johnpulle <dilan@calyx.net.au> Created attachment 63581 [details] [review] Bug 18548: Print usage when missing instance name in koha-create script Test plan: 1. Run: debian/scripts/koha-create --request-db -> Without patch you see the getent error message -> With patch you see usage and "Missing instance name" message Signed-off-by: Dilan Johnpulle <dilan@calyx.net.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Josef! This patch has been pushed to 16.11.x and will be in 16.11.09. Pushed to 16.05.x, for 16.05.15 release |