| Summary: | Borrower debarments do not show on member detail page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Barton Chittenden <barton> |
| Component: | Patrons | Assignee: | Aleisha Amohia <aleisha> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | aleisha, gmcharlt, kyle.m.hall, kyle, m.de.rooy, sally.healey, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 18647 | ||
| Attachments: |
Bug 18552: Borrower debarments not showing on member detail page
Bug 18552: Borrower debarments not showing on member detail page Bug 18552: Borrower debarments not showing on member detail page Bug 18552: [QA Follow-up] Resolve warnings Bug 18552: [16.11.X] Borrower debarments not showing on member detail page Bug 18552: [16.11.X] [QA Follow-up] Resolve warnings |
||
Created attachment 63551 [details] [review] Bug 18552: Borrower debarments not showing on member detail page To test: 1) Go to a borrowers details page and create a manual restriction 2) Notice the restriction shows at the top of the page but the restriction tab says the member is currently unrestricted 3) Apply patch and refresh page 4) Restrictions tab should now correctly show debarments and correct number is shown 5) Confirming deleting and adding restrictions still works as expected Sponsored-by: Catalyst IT Created attachment 63557 [details] [review] Bug 18552: Borrower debarments not showing on member detail page To test: 1) Go to a borrowers details page and create a manual restriction 2) Notice the restriction shows at the top of the page but the restriction tab says the member is currently unrestricted 3) Apply patch and refresh page 4) Restrictions tab should now correctly show debarments and correct number is shown 5) Confirming deleting and adding restrictions still works as expected Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 63576 [details] [review] Bug 18552: Borrower debarments not showing on member detail page To test: 1) Go to a borrowers details page and create a manual restriction 2) Notice the restriction shows at the top of the page but the restriction tab says the member is currently unrestricted 3) Apply patch and refresh page 4) Restrictions tab should now correctly show debarments and correct number is shown 5) Confirming deleting and adding restrictions still works as expected Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 63577 [details] [review] Bug 18552: [QA Follow-up] Resolve warnings Like: Problem = a value of AutoResumeSuspendedHolds has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137. Problem = a value of relatives_borrowernumbers has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137. Problem is functions returning undef in list context (in this case housebound_role). No need to call Patrons::find a second time. Note: The call of GetDebarments in the first patch suffered from this too. It is in a fine place now too. But strictly speaking, should not have been moved. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.05, thanks Marcel! Patch doesn't apply cleanly to 16.11.x - please rebase! (In reply to Kyle M Hall from comment #5) > Pushed to master for 17.05, thanks Marcel! Don't forget Aleisha :) Created attachment 63597 [details] [review] Bug 18552: [16.11.X] Borrower debarments not showing on member detail page To test: 1) Go to a borrowers details page and create a manual restriction 2) Notice the restriction shows at the top of the page but the restriction tab says the member is currently unrestricted 3) Apply patch and refresh page 4) Restrictions tab should now correctly show debarments and correct number is shown 5) Confirming deleting and adding restrictions still works as expected Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 63598 [details] [review] Bug 18552: [16.11.X] [QA Follow-up] Resolve warnings Like: Problem = a value of AutoResumeSuspendedHolds has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137. Problem = a value of relatives_borrowernumbers has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137. Problem is functions returning undef in list context (in this case housebound_role). No need to call Patrons::find a second time. Note: The call of GetDebarments in the first patch suffered from this too. It is in a fine place now too. But strictly speaking, should not have been moved. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> We resolved one bug here to reveal another one. See bug 18647. Hi Marcel, I have a problem using the patches here. When I access a patron account in staff I see "Internal server error". The plack error log shows: Template process failed: undef error - The method category_type is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. All good - works with the follow-up on bug 18647. These patches have been pushed to 16.11.x and will be in 16.11.09. |
To re-create: 1) Scan a borrower's cardnumber into the 'Check out' text area on the main page. 2) Click on the restrictions tab and set a manual restriction. 3) This will show Restricted: Patron's account is restricted until xxx with the explanation: yyyy 4) Click on the 'details' tab on the left. The restriction message shows at the top of the page, but 5) Click on the restrictions tab on the bottom of the page, the text under that tab shows: Patron is currently unrestricted. Add manual restriction I have replicated this issue in 16.11 and master.