Summary: | Create patron list from patron import | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Patrons | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4115 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 18555: Create patron list from patron import
Bug 18555: Create patron list from patron import [SIGNED-OFF] Bug 18555: Create patron list from patron import Bug 18555: (QA-Followup) Remove duplicate code Bug 18555: Create patron list from patron import Bug 18555: (QA-Followup) Remove duplicate code |
Description
Marc Véron
2017-05-08 14:16:47 UTC
Created attachment 63241 [details] [review] Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons https://bugs.koha-community.org/show_bug.cgi?id=15855 Created attachment 63242 [details] [review] Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons Created attachment 63284 [details] [review] [SIGNED-OFF] Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Still applies on current master Nice! A couple things: 1 - Duplicated code for testing the input and generating the list name - we should really only bother inside the check to create a list or not 2 - We should link from the results page to the newly created list 3 - We may want to optionally include overwritten borrowers in the list, they are sort of imported - I see use case in a school that overwrites patrons to update contact info/expiration and may generate new cards regularly -not blocker but would be nice (In reply to Nick Clemens from comment #5) > Nice! A couple things: > > 1 - Duplicated code for testing the input and generating the list name - we > should really only bother inside the check to create a list or not > 2 - We should link from the results page to the newly created list > 3 - We may want to optionally include overwritten borrowers in the list, > they are sort of imported - I see use case in a school that overwrites > patrons to update contact info/expiration and may generate new cards > regularly -not blocker but would be nice Hi Nick Can you elaborate a little bit what you mean by 1) ? 2) and 3) could go to a new bug based on this one - I have not much time ATM. Marc (In reply to Marc Véron from comment #6) > (In reply to Nick Clemens from comment #5) > Can you elaborate a little bit what you mean by 1) ? 109 #create a patronlist 110 my $createpatronlist = $input->param('createpatronlist') || 0; 111 my $dt = dt_from_string(); 112 my $timestamp = $dt->ymd('-').' '.$dt->hms(':'); 113 my $patronlistname = $uploadborrowers . ' (' . $timestamp .')'; 124 #create a patronlist 125 my $createpatronlist = $input->param('createpatronlist'); 126 my $dt = dt_from_string(); 127 my $timestamp = $dt->ymd('-').' '.$dt->hms(':'); 128 my $patronlistname = $uploadborrowers. ' (' . $timestamp .')'; We do this twice - if createpatronlist isn't checked we don't need to do the rest of the setup > > 2) and 3) could go to a new bug based on this one - I have not much time ATM. I will try to provide a followup or open a new bug for these. Created attachment 65614 [details] [review] Bug 18555: (QA-Followup) Remove duplicate code Remove duplicate code as of comment #7 Hope it's OK to set back to SO. Created attachment 65852 [details] [review] Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Marc Véron from comment #6) > 2) and 3) could go to a new bug based on this one - I have not much time ATM. Could you open them please? Created attachment 65853 [details] [review] Bug 18555: (QA-Followup) Remove duplicate code Remove duplicate code as of comment #7 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Enhancement not pushed to 17.05.x |