| Summary: | Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 12461 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable
[SIGNED-OFF] Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Bug 18557 [QA Followup] - Use dt_from_string Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Bug 18557 [QA Followup] - Use dt_from_string |
||
|
Description
Jonathan Druart
2017-05-08 18:09:04 UTC
Created attachment 63281 [details] [review] Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Test Plan: 1) Apply this patch 2) prove t/db_dependent/Clubs.t Created attachment 63285 [details] [review] [SIGNED-OFF] Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Test Plan: 1) Apply this patch 2) prove t/db_dependent/Clubs.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Kyle, my understanding is that the best would be to use dt_from_string:
my $dtf = Koha::Database->new->schema->storage->datetime_parser;
then
->search({ date_end => { '>=' => $dtf->format_datetime( dt_from_string() ) } })
Do not you think?
(In reply to Jonathan Druart from comment #3) > Kyle, my understanding is that the best would be to use dt_from_string: > > my $dtf = Koha::Database->new->schema->storage->datetime_parser; > then > ->search({ date_end => { '>=' => $dtf->format_datetime( dt_from_string() ) > } }) > > Do not you think? That works for me! Followup incoming! Created attachment 63290 [details] [review] Bug 18557 [QA Followup] - Use dt_from_string Created attachment 63305 [details] [review] Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable Test Plan: 1) Apply this patch 2) prove t/db_dependent/Clubs.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 63306 [details] [review] Bug 18557 [QA Followup] - Use dt_from_string Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05! |