Bug 18566

Summary:	Create separate prefs for activating/deactivating suggestions in OPAC and staff interface
Product:	Koha	Reporter:	Vinod <mishravk79>
Component:	Acquisitions	Assignee:	Bugs List <koha-bugs>
Status:	NEW ---	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	indradg, mishravk79
Version:	16.11
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:

Description Vinod 2017-05-10 04:41:46 UTC

Koha allows the staff to put the purchase suggestions on users behalf through staff interface though in system preferences it has been marked as "not allowed". But acquisition home page is missing "suggestion management" link therefore staff is not able to view the same if he/she has made suggestions on users behalf.

The requirement is it should always show the suggestions whether system preference allows or not allows the users to make suggestions via OPAC.

I have tested it on 16.11.07 installed on debian via package.

Comment 1 Owen Leonard 2017-05-10 15:05:22 UTC

I think there are two related problems here:

1) There isn't a separate preference for enabling and disabling suggestions in the OPAC and staff client. Having that would allow you to enable staff-mediated suggestions through the staff client but not OPAC suggestions.

2) Turning off suggestions in system preferences hides suggestion management in Acquisitions and the OPAC, but not from the patron tabs in circulation. As long as there is only one suggestions system preference I would think turning it off would  hide the option of accessing suggestions-related pages everywhere, including members/purchase-suggestions.pl

Comment 2 Vinod 2017-05-10 15:20:00 UTC

I tested and found the link is however working and shows suggestion management if directly we give URL of suggestion management even it is off in system preference.

There is some problematic situation as i tested:

1. Created suggestion on user behalf through staff interfacewhen system preference is off.

2. Came to Koha staff interface and selected the displayed pending suggestion.

3. Made this suggestion status as checked and came back to staff home page.

4. Now i wish to find above title for further process but did not able to locate only it can be seen again in concern member detail page ( Point no. 1 above)

5. I directly given URL of suggestion management and found on the screen which showed me as usual options of suggestion management and title status as checked.

I think few more options is needed in this regard. 

1. Display of suggestion management always in staff client as well as in member detail page only through staff interface.

2. Purchase suggestion is needed by category of members and that can be made in circulation privileges OR category of member i.e. Purchase suggestion allowed or not

Comment 3 Katrin Fischer 2020-04-19 11:23:34 UTC

I would suggest the following:

- Rename suggestion to OpacSuggestions.
- Add a new system preference StaffSuggestions that will also include the purchase suggetions tab in the patron account in staff.

Because if we only fixed the link in the staff patron account now to also be governed by the suggestion pref, it will break the workflow for people working around the issue (see comment#2)

Would this work?