Bug 18572

Summary: Improper branchcode set during OPAC renewal
Product: Koha Reporter: Nick Clemens <nick>
Component: OPACAssignee: Nick Clemens <nick>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: nick, techservspec
Version: master   
Hardware: All   
OS: All   
Whiteboard:
Change sponsored?: --- Patch complexity: ---
Bot Control: --- When did the bot last check this:
Who signed the patch off: Text to go in the release notes:
Bug Depends on: 17781    
Bug Blocks:    
Attachments: Bug 18572 - Improper branchcode set during OPAC renewal
Bug 18572 - Improper branchcode set during OPAC renewal
Bug 18572 - Improper branchcode set during OPAC renewal

Description Nick Clemens 2017-05-10 15:31:36 UTC
Bug 17781 fixed an inconsistency in renewals, but it broke functionality in the OPAC

To recreate:
1 - Set 'OpacRenewalBranch' to 'OPACrenew'
2 - Renew an item via the OPAC
3 - Check the statistics table
4 - Branch will be the user's branch, not OPACrenew
Comment 1 Nick Clemens 2017-06-23 13:21:46 UTC
Created attachment 64596 [details] [review]
Bug 18572 - Improper branchcode set during OPAC renewal

To test:
1 - Set 'OpacRenewalBranch' to various settings
2 - Renew an item for a ptron under each setting
3 - Confirm action_log entries reflect the correct branch for each
secnario
4 - prove t/db_dependent/Circulation/issue.t
Comment 2 David Kuhn 2017-06-24 20:14:54 UTC
Created attachment 64609 [details] [review]
Bug 18572 - Improper branchcode set during OPAC renewal

To test:
1 - Set 'OpacRenewalBranch' to various settings
2 - Renew an item for a ptron under each setting
3 - Confirm action_log entries reflect the correct branch for each
secnario
4 - prove t/db_dependent/Circulation/issue.t

Signed-off-by: David Kuhn <techservspec@gmail.com>
Comment 3 David Kuhn 2017-06-24 20:30:59 UTC
Created attachment 64610 [details] [review]
Bug 18572 - Improper branchcode set during OPAC renewal

To test:
1 - Set 'OpacRenewalBranch' to various settings
2 - Renew an item for a ptron under each setting
3 - Confirm action_log entries reflect the correct branch for each
secnario
4 - prove t/db_dependent/Circulation/issue.t

Step 3 in the above test should refer to entries in the statistics table as that was where the problem was originally noticed.

Signed-off-by: David Kuhn <techservspec@gmail.com>