Summary: | Error when adding a suggestion in the OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | julian.maurice, kyle, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 17847 | ||
Bug Blocks: | |||
Attachments: |
Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC
Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC |
Description
Owen Leonard
2017-05-10 15:38:09 UTC
On bug 17847, av-build-dropbox.inc has been updated for the intranet, not OPAC Created attachment 63356 [details] [review] Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC On bug 17847, av-build-dropbox.inc has been updated for the intranet, not OPAC There is only one call to av-build-dropbox.inc at the OPAC, from opac-suggestion.tt Test plan: Create a new suggestion, anonymous or with a logged in user => Without this patch you got Template process failed: undef error - The method default is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. => With this patch applied you should see the item type dropdown list correctly filled Created attachment 63369 [details] [review] Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC On bug 17847, av-build-dropbox.inc has been updated for the intranet, not OPAC There is only one call to av-build-dropbox.inc at the OPAC, from opac-suggestion.tt Test plan: Create a new suggestion, anonymous or with a logged in user => Without this patch you got Template process failed: undef error - The method default is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. => With this patch applied you should see the item type dropdown list correctly filled Reproduced without patch, OK with patch Signed-off-by: Marc Véron <veron@veron.ch> QAing this now Created attachment 63379 [details] [review] Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC On bug 17847, av-build-dropbox.inc has been updated for the intranet, not OPAC There is only one call to av-build-dropbox.inc at the OPAC, from opac-suggestion.tt Test plan: Create a new suggestion, anonymous or with a logged in user => Without this patch you got Template process failed: undef error - The method default is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. => With this patch applied you should see the item type dropdown list correctly filled Reproduced without patch, OK with patch Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 17.05, thanks Jonathan! Dependency is not part of 16.11.x, so this should not be needed there. |