Summary: | Clean Patron Records tool doesn't limit to the selected library | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Tools | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | jonathan.druart, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 17083 | ||
Bug Blocks: | |||
Attachments: |
Bug 18574 - Clean Patron Records tool doesn't limit to the selected library
[SIGNED OFF] Bug 18574 - Clean Patron Records tool doesn't limit to the selected library Bug 18574 - Clean Patron Records tool doesn't limit to the selected library |
Description
Kyle M Hall (khall)
2017-05-10 15:46:20 UTC
Created attachment 63355 [details] [review] Bug 18574 - Clean Patron Records tool doesn't limit to the selected library The library selector simply does nothing because at some point the javascript that powers it was removed. This is very bad because the librarian may batch delete patrons assuming it is limiting by branch correctly and instead delete patrons for all the libraries! Test Plan: 1) Note that the library pulldown on tools/cleanborrowers.pl does nothing 2) Apply this patch 3) Note that chaning the value in the pulldown now refreshed the page and sets the library correctly! Indentation is wrong. Created attachment 63374 [details] [review] [SIGNED OFF] Bug 18574 - Clean Patron Records tool doesn't limit to the selected library The library selector simply does nothing because at some point the javascript that powers it was removed. This is very bad because the librarian may batch delete patrons assuming it is limiting by branch correctly and instead delete patrons for all the libraries! Test Plan: 1) Note that the library pulldown on tools/cleanborrowers.pl does nothing 2) Apply this patch 3) Note that chaning the value in the pulldown now refreshed the page and sets the library correctly! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Fixed the tabs! QAing this now Created attachment 63378 [details] [review] Bug 18574 - Clean Patron Records tool doesn't limit to the selected library The library selector simply does nothing because at some point the javascript that powers it was removed. This is very bad because the librarian may batch delete patrons assuming it is limiting by branch correctly and instead delete patrons for all the libraries! Test Plan: 1) Note that the library pulldown on tools/cleanborrowers.pl does nothing 2) Apply this patch 3) Note that chaning the value in the pulldown now refreshed the page and sets the library correctly! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Passed QA For reference, this bug was introduced by bug 17083 Pushed to master for 17.05! Thanks for the quick turnaround Katrin, Julian! This patch has been pushed to 16.11.x and will be in 16.11.08. |