| Summary: | Account-pay does not apply credits / clear old fines as did recordpayment | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
| Component: | Circulation | Assignee: | Colin Campbell <colin.campbell> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P1 - high | CC: | cgdavis, gmcharlt, jpalmer, kyle, martin.renvoize, sally.healey, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 15899 | ||
| Bug Blocks: | |||
| Attachments: | proposed patch | ||
|
Description
Colin Campbell
2017-05-11 14:48:19 UTC
Created attachment 63386 [details] [review] proposed patch This is a minimal patch which restores the previous behaviour which some operations relied on. Its a bit of a code smell that this is handled as a side-effect of a payment, but as Accounts never explicitly handled credit amounts it would require a bit of a rethink to the Accounts api Upped priority as we are finding sites on upgrade to 16.11 and beyond repeatedly enocountering inability to pay off fines as a result of this Hi Colin, I think the behaviour is still a bit odd. Your patch works, but only if the fine was created first. I think sequence should not matter? I have made sure to restart Plack after applying the patch: Test plan: 1) Created to fines, 1.00 each 2) Created a credit, 1.00 3) Balance is at 1.00 4) Pay amount of 1.00 1.00 is paid, Credit and other fine remain unchanged (amount <> 0) 1) Created a credit, 1.00 2) Created to fines, 1.00 each 3) Balance is at 1.00 4) Pay amount of 1.00 All amount outstanding are set to 0.00. Good. I appears it only works if the credit was created before the fines were. I used a fresh patron account for each test. (In reply to Katrin Fischer from comment #3) > Hi Colin, > I think the behaviour is still a bit odd. Your patch works, but only if the > fine was created first. I think sequence should not matter? > > I have made sure to restart Plack after applying the patch: > > Test plan: > 1) Created to fines, 1.00 each > 2) Created a credit, 1.00 > 3) Balance is at 1.00 > 4) Pay amount of 1.00 > 1.00 is paid, Credit and other fine remain unchanged (amount <> 0) > > 1) Created a credit, 1.00 > 2) Created to fines, 1.00 each > 3) Balance is at 1.00 > 4) Pay amount of 1.00 > All amount outstanding are set to 0.00. Good. > > I appears it only works if the credit was created before the fines were. > I used a fresh patron account for each test. I'll see if I can set up something to confirm what the old api did and see if I can see anywhere the new fails Hi Everyone, My institution is seeing this behaviour several time per week since our upgrade to Koha v. 18.05.05. |