Bug 18582

Summary: Hide empty rows in detailed suggestion view
Product: Koha Reporter: Owen Leonard <oleonard>
Component: AcquisitionsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/suggestion/suggestion.pl
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 18582 - Hide empty rows in detailed suggestion view
[SIGNED-OFF] Bug 18582 - Hide empty rows in detailed suggestion view
Bug 18582 - Hide empty rows in detailed suggestion view

Description Owen Leonard 2017-05-11 15:10:21 UTC
In the suggestion detailed view, every field is displayed even if it is empty. This view should hide rows which contain no data.
Comment 1 Owen Leonard 2017-05-11 16:49:32 UTC
Created attachment 63391 [details] [review]
Bug 18582 - Hide empty rows in detailed suggestion view

This patch adds a check for the existence of various template variables
before showing the row containing that data. This will prevent the
display of rows containing labels but no data in the suggestions
detailed view.

To test, apply the patch and go to Acquisitions -> Suggestions.

View the detail page of various suggestions and confirm that only fields
with data are displaying.
Comment 2 Josef Moravec 2017-05-12 10:28:40 UTC
Created attachment 63422 [details] [review]
[SIGNED-OFF] Bug 18582 - Hide empty rows in detailed suggestion view

This patch adds a check for the existence of various template variables
before showing the row containing that data. This will prevent the
display of rows containing labels but no data in the suggestions
detailed view.

To test, apply the patch and go to Acquisitions -> Suggestions.

View the detail page of various suggestions and confirm that only fields
with data are displaying.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 3 Brendan Gallagher 2017-06-16 20:44:55 UTC
Created attachment 64419 [details] [review]
Bug 18582 - Hide empty rows in detailed suggestion view

This patch adds a check for the existence of various template variables
before showing the row containing that data. This will prevent the
display of rows containing labels but no data in the suggestions
detailed view.

To test, apply the patch and go to Acquisitions -> Suggestions.

View the detail page of various suggestions and confirm that only fields
with data are displaying.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 4 Jonathan Druart 2017-06-19 19:37:44 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 5 Fridolin Somers 2017-06-29 07:16:57 UTC
Enhancement not pushed to 17.05.x