Summary: | Quick add form doesn't clear values when switching | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Patrons | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, kyle, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 3534 | ||
Bug Blocks: | |||
Attachments: |
Bug 18598 - Quick add form doesn't clear values when switching
Bug 18598 - Quick add form doesn't clear values when switching Bug 18598 - Quick add form doesn't clear values when switching Bug 18598 - Quick add form doesn't clear values when switching |
Description
Nick Clemens (kidclamp)
2017-05-12 14:30:28 UTC
Created attachment 63445 [details] [review] Bug 18598 - Quick add form doesn't clear values when switching To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved 8 - Apply patch 9 - Repeat 1-6 - values should be cleared and not saved I can reproduce the behaviour without patch. With patch, clearing works as described. However, with patch applied the values e.g. for surname are no longer transferred between the two forms. If I enter a surname AAA in quick add form and switch to full form, surname is empty. If then in full form I enter BBB as surname and switch back to quick add form, there is still AAA. Switching back to full form shows BBB. Created attachment 63554 [details] [review] Bug 18598 - Quick add form doesn't clear values when switching To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved 8 - Apply patch 9 - Repeat 1-6 - values should be cleared and not saved Yeah, I removed one too many lines in that first patch ( meant to remove the if condtiion, removed the whole block ) Created attachment 63556 [details] [review] Bug 18598 - Quick add form doesn't clear values when switching To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved 8 - Apply patch 9 - Repeat 1-6 - values should be cleared and not saved Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 63638 [details] [review] Bug 18598 - Quick add form doesn't clear values when switching To test: 1 - Fill out some fields in quick add 2 - Switch to full form and clear fields 3 - Switch back and fields are still populated 4 - Fill a field in long form 5 - Switch to quick add and clear it 6 - Save 7 - Value set in 4 is saved 8 - Apply patch 9 - Repeat 1-6 - values should be cleared and not saved Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Nick! This patch has been pushed to 16.11.x and will be in 16.11.09. |