Summary: | OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios
[SIGNED-OFF] Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios |
Description
Marcel de Rooy
2017-05-15 07:11:34 UTC
Created attachment 63460 [details] [review] Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios This patch replaces the TRUNCATE statement in ModOAISetsBiblios by a DELETE statement. A truncate will cause an implicit commit and will therefore commit the transaction started in the test script. Also simplifying the module load in the test script. Test plan: Do not apply this patch and observe that biblio records are added to your database by running t/db_dependent/OAI/Sets.t. Apply this patch, run the test again and verify that it does no longer add records to your biblio table. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 63670 [details] [review] [SIGNED-OFF] Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios This patch replaces the TRUNCATE statement in ModOAISetsBiblios by a DELETE statement. A truncate will cause an implicit commit and will therefore commit the transaction started in the test script. Also simplifying the module load in the test script. Test plan: Do not apply this patch and observe that biblio records are added to your database by running t/db_dependent/OAI/Sets.t. Apply this patch, run the test again and verify that it does no longer add records to your biblio table. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 64269 [details] [review] Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios This patch replaces the TRUNCATE statement in ModOAISetsBiblios by a DELETE statement. A truncate will cause an implicit commit and will therefore commit the transaction started in the test script. Also simplifying the module load in the test script. Test plan: Do not apply this patch and observe that biblio records are added to your database by running t/db_dependent/OAI/Sets.t. Apply this patch, run the test again and verify that it does no longer add records to your biblio table. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 This patch has been pushed to 16.11.x and will be in 16.11.09. Pushed to 16.05.x, for 16.05.15 release |