Summary: | Remove TRUNCATE from C4/HoldsQueue.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm
[SIGNED-OFF] Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm |
Description
Marcel de Rooy
2017-05-15 08:30:39 UTC
Created attachment 63462 [details] [review] Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm Replaces TRUNCATE by DELETE, since truncate implicitly commits. We don't need to do that here. (Would complicate testing it too.) Fixes typo disablig. Add a simple test to HoldsQueue.t. Test plan: Run t/db_dependent/HoldsQueue.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 64740 [details] [review] [SIGNED-OFF] Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm Replaces TRUNCATE by DELETE, since truncate implicitly commits. We don't need to do that here. (Would complicate testing it too.) Fixes typo disablig. Add a simple test to HoldsQueue.t. Test plan: Run t/db_dependent/HoldsQueue.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> (In reply to M. Tompsett from comment #2) > Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Thx Created attachment 65174 [details] [review] Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm Replaces TRUNCATE by DELETE, since truncate implicitly commits. We don't need to do that here. (Would complicate testing it too.) Fixes typo disablig. Add a simple test to HoldsQueue.t. Test plan: Run t/db_dependent/HoldsQueue.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.03. This patch has been pushed to 16.11.x and will be in 16.11.11. Pushed to 16.05.x, for 16.05.16 release |