| Summary: | ElasticSearch indexing of facets needs to be updated for newer Catmandu versions | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Searching | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 18434 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 18610: regression tests
Bug 18610: Make facet indexing append instead of overwrite so it works on newer Catmandu |
||
|
Description
Nick Clemens (kidclamp)
2017-05-15 14:48:51 UTC
Created attachment 63480 [details] [review] Bug 18610: regression tests This patch introduces tests fr K::SE::ES::Indexer::_convert_marc_to_json to test the facets that get extracted from the sample record. To test: - Run $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t \ t/db_dependent/Koha_Elasticsearch.t => FAIL: Test fails because only last field mapped for facetting is considered (overwrite behaviour). Sponsored-by: ByWater Solutions Created attachment 63481 [details] [review] Bug 18610: Make facet indexing append instead of overwrite so it works on newer Catmandu This patch makes get_fixer_rules add the $append string to the facets mapping as we did for bug 18434. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t t/db_dependent/Koha_Elasticsearch.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t t/db_dependent/Koha_Elasticsearch.t => SUCCESS: Tests are all green! - Sign off :-D Sponsored-by: ByWater Solutions |