Description
Barton Chittenden
2017-05-15 16:37:40 UTC
As a work-around, create a report of valid barcodes in a given import batch using the query found here: https://wiki.koha-community.org/wiki/SQL_Reports_Library#Workaround_for_Bug_18611 Created attachment 63483 [details] [review] Bug 18611 - Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. To test: 1 - Import a batch with some items 2 - Delete one of the imported items 3 - Browse to Tools->Staged MARC record management 4 - Click (Create label batch) for the batch you imported 5 - Recieve an error 6 - Apply patch 7 - Click (Create label batch) 8 - Batch is created with remaning items from the import Created attachment 63667 [details] [review] Bug 18611 - Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. To test: 1 - Import a batch with some items 2 - Delete one of the imported items 3 - Browse to Tools->Staged MARC record management 4 - Click (Create label batch) for the batch you imported 5 - Recieve an error 6 - Apply patch 7 - Click (Create label batch) 8 - Batch is created with remaning items from the import Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 63668 [details] [review] [SIGNED-OFF] Bug 18611 - Followup, remove tabs to make qa tools happy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 63669 [details] [review] Bug 18611 - Followup, remove tabs to make qa tools happy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 63728 [details] [review] Bug 18611 - Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. To test: 1 - Import a batch with some items 2 - Delete one of the imported items 3 - Browse to Tools->Staged MARC record management 4 - Click (Create label batch) for the batch you imported 5 - Recieve an error 6 - Apply patch 7 - Click (Create label batch) 8 - Batch is created with remaning items from the import Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 63729 [details] [review] Bug 18611 - Followup, remove tabs to make qa tools happy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 63730 [details] [review] Bug 18611: [QA Follow-up] Make SQL query more readable Make it more explicit by adding join statements. Test plan: See next patch for adding a unit test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 63731 [details] [review] Bug 18611: [QA Follow-up] Add unit test for GetItemNumbersFromImportBatch Test plan: Run t/db_dependent/ImportBatch.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.05, thanks Nick, Josef, Marcel! These patches have been pushed to 16.11.x and will be in 16.11.09. Pushed to 16.05.x, for 16.05.15 release |