| Summary: | After duplicate message system picks category expiry date rather than manual defined | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Vinod <mishravk79> |
| Component: | Patrons | Assignee: | Alex Buckley <alexbuckley> |
| Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | alexbuckley, fridolin.somers, gmcharlt, kyle.m.hall, kyle, ldjamison, mtj |
| Version: | 16.11 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 18621: Added in value attribute to dateexpiry field
[SIGNED-OFF] Bug 18621: Added in value attribute to dateexpiry field Bug 18621: Added in value attribute to dateexpiry field |
||
|
Description
Vinod
2017-05-17 17:25:44 UTC
Tested following described steps and appears to still exist on current master. Created attachment 65003 [details] [review] Bug 18621: Added in value attribute to dateexpiry field Test plan: 1. Create a patron category with the dateexpiry value of 29/9/2017 2. Create a patron user from that patron category (which I'll refer to as patron A) with the date expiry value of 1/10/2017 and submit the form 3. Notice that the manual dateexpiry you have submitted is correctly displayed 4. Create a duplicate patron with the same firstname and surname and patron A, and set the date expiry value of 1/10/2017 and submit the form 5. The form displays a duplicate patron message. Notice that the dateexpiry input box is empty now 6. Select the new member (not a duplicate member) option in the messagebox 7. The form successfully submits and notice that the date expiry value displayed is that of the patron category (i.e. it is 29/9/2017) not the dateexpiry value of 1/10/2017 that you manually set for this patron 8. Apply patch 9. Repeat step 4 10. The form displays a duplicate patron message. Notice the dateexpiry input box still contains the value you entered which is 1/10/2017. Select the new member (not a duplicate member) option in the messagebox 11. The form successfully submits and notice that the date expiry value displayed is 1/10/2017 that you manually set for this patron I am a bit confused by this, but the patch doesn't appear to fix the problem. 1) Add a new patron - same first and last name as an existing one - edit expiration date to 01/01/2022 2) Save and cause duplicate message - Note: expiration date field is empty now 3) Save as new - Verify date has been calculated Same behaviour after applying patch, restarting plack. I am using the default patron categories where the expiration is defined in months. Alex has sent me an email showing it works for him - but it still doesn't work for me. I am out of ideas :( Best someone else picks this up for testing! Created attachment 66102 [details] [review] [SIGNED-OFF] Bug 18621: Added in value attribute to dateexpiry field Test plan: 1. Create a patron category with the dateexpiry value of 29/9/2017 2. Create a patron user from that patron category (which I'll refer to as patron A) with the date expiry value of 1/10/2017 and submit the form 3. Notice that the manual dateexpiry you have submitted is correctly displayed 4. Create a duplicate patron with the same firstname and surname and patron A, and set the date expiry value of 1/10/2017 and submit the form 5. The form displays a duplicate patron message. Notice that the dateexpiry input box is empty now 6. Select the new member (not a duplicate member) option in the messagebox 7. The form successfully submits and notice that the date expiry value displayed is that of the patron category (i.e. it is 29/9/2017) not the dateexpiry value of 1/10/2017 that you manually set for this patron 8. Apply patch 9. Repeat step 4 10. The form displays a duplicate patron message. Notice the dateexpiry input box still contains the value you entered which is 1/10/2017. Select the new member (not a duplicate member) option in the messagebox 11. The form successfully submits and notice that the date expiry value displayed is 1/10/2017 that you manually set for this patron Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 66715 [details] [review] Bug 18621: Added in value attribute to dateexpiry field Test plan: 1. Create a patron category with the dateexpiry value of 29/9/2017 2. Create a patron user from that patron category (which I'll refer to as patron A) with the date expiry value of 1/10/2017 and submit the form 3. Notice that the manual dateexpiry you have submitted is correctly displayed 4. Create a duplicate patron with the same firstname and surname and patron A, and set the date expiry value of 1/10/2017 and submit the form 5. The form displays a duplicate patron message. Notice that the dateexpiry input box is empty now 6. Select the new member (not a duplicate member) option in the messagebox 7. The form successfully submits and notice that the date expiry value displayed is that of the patron category (i.e. it is 29/9/2017) not the dateexpiry value of 1/10/2017 that you manually set for this patron 8. Apply patch 9. Repeat step 4 10. The form displays a duplicate patron message. Notice the dateexpiry input box still contains the value you entered which is 1/10/2017. Select the new member (not a duplicate member) option in the messagebox 11. The form successfully submits and notice that the date expiry value displayed is 1/10/2017 that you manually set for this patron Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.05. This patch has been pushed to 16.11.x and will be in 16.11.13. Pushed to 16.05.x, for 16.05.18 release |