Bug 18621

Summary: After duplicate message system picks category expiry date rather than manual defined
Product: Koha Reporter: Vinod <mishravk79>
Component: PatronsAssignee: Alex Buckley <alexbuckley>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: alexbuckley, gmcharlt, katrin.fischer, kyle.m.hall, ldjamison
Version: 16.11   
Hardware: All   
OS: All   
Whiteboard:
Change sponsored?: --- Patch complexity: ---
Bot Control: --- When did the bot last check this:
Who signed the patch off: Text to go in the release notes:
Attachments: Bug 18621: Added in value attribute to dateexpiry field
[SIGNED-OFF] Bug 18621: Added in value attribute to dateexpiry field

Description Vinod 2017-05-17 17:25:44 UTC
After duplicate message system picks category expiry date rather than manual defined, the test is as follows:

1. Try to enter a new member 
2. Give member Expiry date which is more than defined in concern category 
3. If Koha found similar member than pop up a message
4. Select not a duplicate member (New member option)
5. Koha saved the record but the expiry date will pick from category rather than you assigned the member.

6. If the member is new and no message is populated than it will save expiry date as you defined.

Koha version 16.11.07 on debian Jessie installed by package.
Comment 1 Lee Jamison 2017-06-17 15:24:03 UTC
Tested following described steps and appears to still exist on current master.
Comment 2 Alex Buckley 2017-07-11 22:31:51 UTC
Created attachment 65003 [details] [review]
Bug 18621: Added in value attribute to dateexpiry field

Test plan:
1. Create a patron category with the dateexpiry value of 29/9/2017

2. Create a patron user from that patron category (which I'll refer to as patron A) with the date
expiry value of 1/10/2017 and submit the form

3. Notice that the manual dateexpiry you have submitted is correctly
displayed

4. Create a duplicate patron with the same firstname and surname and
patron A, and set the date expiry value of 1/10/2017 and submit the form

5. The form displays a duplicate patron message. Notice that the dateexpiry input box is empty now

6. Select the new member (not a duplicate member) option in the
messagebox

7. The form successfully submits and notice that the date expiry value
displayed is that of the patron category (i.e. it is 29/9/2017) not the
dateexpiry value of 1/10/2017 that you manually set for this patron

8. Apply patch

9. Repeat step 4

10. The form displays a duplicate patron message. Notice the dateexpiry input box still
contains the value you entered which is 1/10/2017. Select the new member
(not a duplicate member) option in the messagebox

11. The form successfully submits and notice that the date expiry value
displayed is 1/10/2017 that you manually set for this patron
Comment 3 Katrin Fischer 2017-08-08 12:21:57 UTC
I am a bit confused by this, but the patch doesn't appear to fix the problem.

1) Add a new patron
  - same first and last name as an existing one
  - edit expiration date to 01/01/2022
2) Save and cause duplicate message
  - Note: expiration date field is empty now
3) Save as new
  - Verify date has been calculated

Same behaviour after applying patch, restarting plack.

I am using the default patron categories where the expiration is defined in months.
Comment 4 Katrin Fischer 2017-08-16 14:17:56 UTC
Alex has sent me an email showing it works for him - but it still doesn't work for me. I am out of ideas :( Best someone else picks this up for testing!
Comment 5 Owen Leonard 2017-08-16 15:08:30 UTC
Created attachment 66102 [details] [review]
[SIGNED-OFF] Bug 18621: Added in value attribute to dateexpiry field

Test plan:
1. Create a patron category with the dateexpiry value of 29/9/2017

2. Create a patron user from that patron category (which I'll refer to as patron A) with the date
expiry value of 1/10/2017 and submit the form

3. Notice that the manual dateexpiry you have submitted is correctly
displayed

4. Create a duplicate patron with the same firstname and surname and
patron A, and set the date expiry value of 1/10/2017 and submit the form

5. The form displays a duplicate patron message. Notice that the dateexpiry input box is empty now

6. Select the new member (not a duplicate member) option in the
messagebox

7. The form successfully submits and notice that the date expiry value
displayed is that of the patron category (i.e. it is 29/9/2017) not the
dateexpiry value of 1/10/2017 that you manually set for this patron

8. Apply patch

9. Repeat step 4

10. The form displays a duplicate patron message. Notice the dateexpiry input box still
contains the value you entered which is 1/10/2017. Select the new member
(not a duplicate member) option in the messagebox

11. The form successfully submits and notice that the date expiry value
displayed is 1/10/2017 that you manually set for this patron

Signed-off-by: Owen Leonard <oleonard@myacpl.org>