Bug 18642

Summary:	Internal Server Error in Guided reports wizard caused by debug messages
Product:	Koha	Reporter:	Marc Véron <veron>
Component:	Installation and upgrade (web-based installer)	Assignee:	Josef Moravec <josef.moravec>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	major
Priority:	P5 - low	CC:	gmcharlt, jonathan.druart, josef.moravec, kyle, tomascohen
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:	17898
Bug Blocks:
Attachments:	Bug 18642: Add missing dependency for Data::Printer module Bug 18642: Remove debug messages Bug 18642: Remove debug messages Bug 18642: Remove debug messages

Description Marc Véron 2017-05-20 08:17:13 UTC

Calling Guided reports wizard from Home > Reports results in an Internal Server Error.
Plack error log says:
Could not compile /home/marc/koha/reports/guided_reports.pl: Can't locate Data/Printer.pm in @INC

It seems that the module Data::Printer is missing, but About page and installation tool do not complain about.

Comment 1 Marc Véron 2017-05-20 08:39:30 UTC

Introduced by first patch in Bug 17898 - Add a way to automatically convert SQL reports

Comment 2 Josef Moravec 2017-05-22 09:53:05 UTC

Created attachment 63607 [details] [review]
Bug 18642: Add missing dependency for Data::Printer module

Test plan:
1) Go to About page
-- without patch you can't see Data::Printer listed
-- with patch you'll see it
2) uninstall Data::Printer - apt-get remove libdata-printer-perl
3) go to Reports -> Use saved - you'll see ISE
4) install the module again - apt-get install libdata-printer-perl
5) go to Reports -> Use saved - everything should work fine

Comment 3 Tomás Cohen Arazi (tcohen) 2017-05-22 10:21:37 UTC

When rebasing the original patches, I introduced the dep for debugging purposes only. We should just remove the code that uses Data::Printer instead!

Comment 4 Josef Moravec 2017-05-22 10:41:10 UTC

Created attachment 63609 [details] [review]
Bug 18642: Remove debug messages

Test plan:
0) Apply the patch
1) git grep Data::Printer
    -> should return no results
2) Go to Reports -> Use saved - should work fine

Comment 5 Josef Moravec 2017-05-22 10:41:52 UTC

(In reply to Tomás Cohen Arazi from comment #3)
> When rebasing the original patches, I introduced the dep for debugging
> purposes only. We should just remove the code that uses Data::Printer
> instead!

Ok, I've attached new patch. Thanks!

Comment 6 Marc Véron 2017-05-22 12:43:43 UTC

Created attachment 63612 [details] [review]
Bug 18642: Remove debug messages

Test plan:
0) Apply the patch
1) git grep Data::Printer
    -> should return no results
2) Go to Reports -> Use saved - should work fine

Signed-off-by: Marc Véron <veron@veron.ch>

Comment 7 Jonathan Druart 2017-05-22 13:01:18 UTC

Created attachment 63615 [details] [review]
Bug 18642: Remove debug messages

Test plan:
0) Apply the patch
1) git grep Data::Printer
    -> should return no results
2) Go to Reports -> Use saved - should work fine

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 8 Kyle M Hall (khall) 2017-05-29 02:15:31 UTC

Pushed to master for 17.05, thanks Josef!

Comment 9 Katrin Fischer 2017-06-05 12:15:09 UTC

Depends on bug 17898 which is not part of 16.11.x.