Summary: | IssueSlip.t is failing - IssueSlip should return if params are not valid | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | kyle, m.de.rooy, mtj |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 17762 | ||
Bug Blocks: | |||
Attachments: |
Bug 18664: Make IssueSlip returns if params are not valid
[SIGNED-OFF] Bug 18664: Make IssueSlip returns if params are not valid Bug 18664: Make IssueSlip returns if params are not valid |
Description
Jonathan Druart
2017-05-23 19:33:10 UTC
Created attachment 63673 [details] [review] Bug 18664: Make IssueSlip returns if params are not valid Problem raised by bug 17762: IssueSlip should return if the params are not valid. The tests contain 2 FIXME to highlight this problem already, it's time to fix them. Note that, theoretically, this change may produce software error. Indeed the caller expecting a hashref (letter) will access the "content" key. But that should not happen. Test plan: Tests must return green Created attachment 63682 [details] [review] [SIGNED-OFF] Bug 18664: Make IssueSlip returns if params are not valid Problem raised by bug 17762: IssueSlip should return if the params are not valid. The tests contain 2 FIXME to highlight this problem already, it's time to fix them. Note that, theoretically, this change may produce software error. Indeed the caller expecting a hashref (letter) will access the "content" key. But that should not happen. Test plan: Tests must return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 63726 [details] [review] Bug 18664: Make IssueSlip returns if params are not valid Problem raised by bug 17762: IssueSlip should return if the params are not valid. The tests contain 2 FIXME to highlight this problem already, it's time to fix them. Note that, theoretically, this change may produce software error. Indeed the caller expecting a hashref (letter) will access the "content" key. But that should not happen. Test plan: Tests must return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.05, thanks Jonathan! |