Bug 18671

Summary:	Calendar.t failing exception holiday test
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Circulation	Assignee:	Bugs List <koha-bugs>
Status:	CLOSED WONTFIX	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	gmcharlt, kyle.m.hall, mtj, veron
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:

Description Katrin Fischer 2017-05-25 18:56:06 UTC

Test is failing on master - I haven't verified yet if that points to a real problem, so just setting to 'normal' for now.

prove t/Calendar.t 
t/Calendar.t .. 1/38 
#   Failed test 'Exception holiday is not a closed day test'
#   at t/Calendar.t line 164.
#          got: '1'
#     expected: '0'
# Looks like you failed 1 test of 38.
t/Calendar.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/38 subtests

Comment 1 Marc Véron 2017-05-29 06:04:05 UTC

It depends on syspref 'CalendarFirstDayOfWeek'

prove -v t/Calendar.t

If CalendarFirstDayOfWeek is set to Sunday, test passes OK
If CalendarFirstDayOfWeekset is set to Monday, test fails with:

not ok 13 - Exception holiday is not a closed day test
#   Failed test 'Exception holiday is not a closed day test'
#   at t/Calendar.t line 164.
#          got: '1'
#     expected: '0'

Comment 2 Katrin Fischer 2020-04-19 11:45:58 UTC

Tests pass with the right standard config, so marking as WONTFIX.