Summary: | Translatability: Get rid of [%% in translation for 2 files av-build-dropbox.inc | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, jonathan.druart, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 18682 - Translatability: Get rid of [%% in translation for 2 files av-build-dropbox.inc
Bug 18682 - Translatability: Get rid of [%% in translation for 2 files av-build-dropbox.inc |
Description
Marc Véron
2017-05-26 18:36:03 UTC
Created attachment 63840 [details] [review] Bug 18682 - Translatability: Get rid of [%% in translation for 2 files av-build-dropbox.inc Two files av-build-dropbox.inc has linebreaks inside template directives, exposing internals (comments and tt code) to translations as mentioned in initial comment. Translators should not be confronted with such interal code. This patch fixes it. To test - Verify, that code changes make sense and have no more line breaks insied tt directives. - Run QA tools in newest version (checking for line breaks inside tt directives) - Bonus test: Create a "language" aa-AA (perl translate create aa-AA from folder misc/translator, verify that lines mentioned above do no longer appear in aa-AA-staff-prog.po and in aa-AA-opac-bootstrap.po Created attachment 63990 [details] [review] Bug 18682 - Translatability: Get rid of [%% in translation for 2 files av-build-dropbox.inc Two files av-build-dropbox.inc has linebreaks inside template directives, exposing internals (comments and tt code) to translations as mentioned in initial comment. Translators should not be confronted with such interal code. This patch fixes it. To test - Verify, that code changes make sense and have no more line breaks insied tt directives. - Run QA tools in newest version (checking for line breaks inside tt directives) - Bonus test: Create a "language" aa-AA (perl translate create aa-AA from folder misc/translator, verify that lines mentioned above do no longer appear in aa-AA-staff-prog.po and in aa-AA-opac-bootstrap.po Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Trivial, skipping QA. Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 This patch has been pushed to 16.11.x and will be in 16.11.09. Pushed to 16.05.x, for 16.05.15 release |