Summary: | Patron edit/cancel floating toolbar out of place | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, lisettepalouse+koha, mtj, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 18551 | ||
Bug Blocks: | |||
Attachments: |
screenshot of toolbar
Bug 18685: (bug 18551 follow-up) Fix patron toolbar [SIGNED-OFF] Bug 18685: (bug 18551 follow-up) Fix patron toolbar Bug 18685: (bug 18551 follow-up) Fix patron toolbar |
Description
Katrin Fischer
2017-05-26 19:30:06 UTC
Created attachment 63755 [details]
screenshot of toolbar
Verified behaviour on 16.11.08 and master.
The original position seems to be defined in memberentrygen.tt, line 15: var additional_height = $("#filters").height(); Not sure, but I guess that this is a side effect of Bug 18551, because filters now are collapsed. Setting this bug as dependent of Bug 18551. Please remove dependency if I'm wrong. I have reverted bug 18551 to restore the former behaviour. Created attachment 64205 [details] [review] Bug 18685: (bug 18551 follow-up) Fix patron toolbar Bug 18551 moves the way the filters are displayed and so the position of the patron toolbar must be recalculated. Test plan: Edit patron's detail open the filters, scrolldown close the filters, scrolldown => The toolbar must be correctly placed Created attachment 64206 [details] [review] [SIGNED-OFF] Bug 18685: (bug 18551 follow-up) Fix patron toolbar Bug 18551 moves the way the filters are displayed and so the position of the patron toolbar must be recalculated. Test plan: Edit patron's detail open the filters, scrolldown close the filters, scrolldown => The toolbar must be correctly placed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 64207 [details] [review] Bug 18685: (bug 18551 follow-up) Fix patron toolbar Bug 18551 moves the way the filters are displayed and so the position of the patron toolbar must be recalculated. Test plan: Edit patron's detail open the filters, scrolldown close the filters, scrolldown => The toolbar must be correctly placed Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Comment on attachment 64207 [details] [review] Bug 18685: (bug 18551 follow-up) Fix patron toolbar Owen was faster - obsoleting my SO patch :-) Skipping QA. Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 Blocked for 16.11.x by 18551 not applying cleanly. This patch has been pushed to 16.11.x and will be in 16.11.11. Pushed to 16.05.x, for 16.05.16 release |