| Summary: | Translatability: abbr tag should not contain lang attribute | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marc Véron <veron> |
| Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | f.demians, fridolin.somers, mtj |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 18687: Translatability: abbr tag should not contain lang attribute
Bug 18687: Translatability: abbr tag should not contain lang attribute Bug 18687: Translatability: abbr tag should not contain lang attribute |
||
|
Description
Marc Véron
2017-05-28 07:29:51 UTC
Created attachment 63767 [details] [review] Bug 18687: Translatability: abbr tag should not contain lang attribute In manage-marc-import.tt, we have an abbreviation: <abbr title="Differences between the original biblio and the imported" lang="en">Diff</abbr> In translations (e.g. German), the line appears as follows: <abbr title="Unterschiede zwischen Originaltitelsatz und importiertem Titelsatz" lang="en">Diff</abbr> The lang attribute is wrong here, it is still "en". The text language is the same as defined at the top of the page - or with other words, the lang tag is superfluous. This patch removes it. To test: Verify that code change makes sense. Still applies on current master Created attachment 65437 [details] [review] Bug 18687: Translatability: abbr tag should not contain lang attribute In manage-marc-import.tt, we have an abbreviation: <abbr title="Differences between the original biblio and the imported" lang="en">Diff</abbr> In translations (e.g. German), the line appears as follows: <abbr title="Unterschiede zwischen Originaltitelsatz und importiertem Titelsatz" lang="en">Diff</abbr> The lang attribute is wrong here, it is still "en". The text language is the same as defined at the top of the page - or with other words, the lang tag is superfluous. This patch removes it. To test: Verify that code change makes sense. Passes QA test and the change is logical Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Created attachment 66638 [details] [review] Bug 18687: Translatability: abbr tag should not contain lang attribute In manage-marc-import.tt, we have an abbreviation: <abbr title="Differences between the original biblio and the imported" lang="en">Diff</abbr> In translations (e.g. German), the line appears as follows: <abbr title="Unterschiede zwischen Originaltitelsatz und importiertem Titelsatz" lang="en">Diff</abbr> The lang attribute is wrong here, it is still "en". The text language is the same as defined at the top of the page - or with other words, the lang tag is superfluous. This patch removes it. To test: Verify that code change makes sense. Passes QA test and the change is logical Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.05. This patch has been pushed to 16.11.x and will be in 16.11.13. Pushed to 16.05.x, for 16.05.18 release |