Summary: | Translatability: Get rid of [%% INCLUDE in translation for circulation.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, jonathan.druart, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 18695: Translatability: Get rid of [%% INCLUDE in translation for circulation.tt
Bug 18695: Translatability: Get rid of [%% INCLUDE in translation for circulation.tt |
Description
Marc Véron
2017-05-30 08:46:55 UTC
Created attachment 63838 [details] [review] Bug 18695: Translatability: Get rid of [%% INCLUDE in translation for circulation.tt The file circ/circulation.tt exposes the following line to translation: %s %s [%% INCLUDE 'blocked-fines.inc' fines = chargesamount %%] %s %s Translators should not be confronted with code internals. This patch fixes it by removing a line break. To test: - Verify that code change makes sense - Run QA tools in newest version (check for line breaks in tt directives) - Bonus test: Create a "language" aa-AA (perl translate create aa-AA from folder misc/translator, verify that line mentioned above do no longer appear in aa-AA-staff-prog.po ) Created attachment 63993 [details] [review] Bug 18695: Translatability: Get rid of [%% INCLUDE in translation for circulation.tt The file circ/circulation.tt exposes the following line to translation: %s %s [%% INCLUDE 'blocked-fines.inc' fines = chargesamount %%] %s %s Translators should not be confronted with code internals. This patch fixes it by removing a line break. To test: - Verify that code change makes sense - Run QA tools in newest version (check for line breaks in tt directives) - Bonus test: Create a "language" aa-AA (perl translate create aa-AA from folder misc/translator, verify that line mentioned above do no longer appear in aa-AA-staff-prog.po ) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Trivial, skipping QA. Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 This patch has been pushed to 16.11.x and will be in 16.11.09. This patch has been pushed to 16.11.x and will be in 16.11.09. Pushed to 16.05.x, for 16.05.15 release |