| Summary: | Translatability: Get rid of exposed tt directives in matching-rules.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marc Véron <veron> |
| Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | f.demians, fridolin.somers, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 18824 | ||
| Attachments: |
Bug 18701: Translatability: Get rid of exposed tt directives in matching-rules.tt
Bug 18701: Translatability: Get rid of exposed tt directives in matching-rules.tt |
||
|
Description
Marc Véron
2017-05-30 15:50:04 UTC
Created attachment 63849 [details] [review] Bug 18701: Translatability: Get rid of exposed tt directives in matching-rules.tt Translation for file matching-rules.tt exposes a lot of template directives. Translators should not be confronted with internal code like the following: [%% PROCESS norms_select selected_norm=\"none\" id=\"mc_1_src_c_1_n_1_norm\" "name=\"mc_1_src_c_1_n_1_norm\" %%] To test: - Apply patch - Verify that code changes make sense (removes line breaks in directives) - Run QA tools in newset version (tests for line breaks in tt) - Bonus test: create a new translation e.g. fpr language 'aa-AA', verify that such lines no longer appear in po/aa-AA-staff-prog.po (for matching-rules.tt) Created attachment 63989 [details] [review] Bug 18701: Translatability: Get rid of exposed tt directives in matching-rules.tt Translation for file matching-rules.tt exposes a lot of template directives. Translators should not be confronted with internal code like the following: [%% PROCESS norms_select selected_norm=\"none\" id=\"mc_1_src_c_1_n_1_norm\" "name=\"mc_1_src_c_1_n_1_norm\" %%] To test: - Apply patch - Verify that code changes make sense (removes line breaks in directives) - Run QA tools in newset version (tests for line breaks in tt) - Bonus test: create a new translation e.g. fpr language 'aa-AA', verify that such lines no longer appear in po/aa-AA-staff-prog.po (for matching-rules.tt) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Trivial, skipping QA. Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 This patch has been pushed to 16.11.x and will be in 16.11.09. |