Summary: | Translatability: Resolve some remaining %%] problems for staff client in 6 Files | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | brendan, f.demians, fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files
[SIGNED-OFF] Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files [SIGNED-OFF] Bug 18703 - Followup, fix typo "statment" Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files Bug 18703 - Followup, fix typo "statment" |
Description
Marc Véron
2017-05-30 18:43:44 UTC
Created attachment 63852 [details] [review] Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files There are some more files that expose parts of tt diretives to translations, mostly due to line breaks inside directives. Files covered with this Bug: koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt To test: - Review code, verify that line breaks are removed - Run QA tools - Bonus test: Create a "language" aa-AA and verify that no fragments containign %%] are picked for the 6 files Created attachment 64031 [details] [review] [SIGNED-OFF] Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files There are some more files that expose parts of tt diretives to translations, mostly due to line breaks inside directives. Files covered with this Bug: koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt To test: - Review code, verify that line breaks are removed - Run QA tools - Bonus test: Create a "language" aa-AA and verify that no fragments containign %%] are picked for the 6 files Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 64032 [details] [review] [SIGNED-OFF] Bug 18703 - Followup, fix typo "statment" Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 64411 [details] [review] Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files There are some more files that expose parts of tt diretives to translations, mostly due to line breaks inside directives. Files covered with this Bug: koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt To test: - Review code, verify that line breaks are removed - Run QA tools - Bonus test: Create a "language" aa-AA and verify that no fragments containign %%] are picked for the 6 files Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Created attachment 64412 [details] [review] Bug 18703 - Followup, fix typo "statment" Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.02 Trivial enhancement and useful for translation on stable branches. These patches have been pushed to 16.11.x and will be in 16.11.10. Changes to members-update.tt did not apply to 16.11.x and were removed from the patch. |