Summary: | File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Tools | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, fridolin.somers, jpalmer, m.de.rooy, mtj, nick, sandboxes, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 18087 | ||
Bug Blocks: | |||
Attachments: |
Bug 18704 - File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel
Bug 18704 - File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel Bug 18704 - File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel |
Description
Nick Clemens (kidclamp)
2017-05-30 19:23:00 UTC
I guess the following patch would fixes the problem: - my @valid_mimetypes = qw( application/octet-stream text/csv text/plain ); + my @valid_mimetypes = qw( application/octet-stream text/csv text/plain application/vnd.ms-excel ); Are we going to create a patch for vendors that provide non-standard mimetype? (Yes I know, this one is certainly the most used). Created attachment 63856 [details] [review] Bug 18704 - File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel To test: 1 - Save a csv of biblionumber from MS/Excel 2 - Attempt to export records using this file 3 - It fails (mimetype is appliction/vnd.ms-excel) 4 - Apply patch 5 - Try again 6 - It succeeds! Patch tested with a sandbox, by Jason Palmer <jpalmer@switchinc.org> Created attachment 63892 [details] [review] Bug 18704 - File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel To test: 1 - Save a csv of biblionumber from MS/Excel 2 - Attempt to export records using this file 3 - It fails (mimetype is appliction/vnd.ms-excel) 4 - Apply patch 5 - Try again 6 - It succeeds! Signed-off-by: Jason Palmer <jpalmer@switchinc.org> Executed plan in test environment. Works as desired. Created attachment 63932 [details] [review] Bug 18704 - File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel To test: 1 - Save a csv of biblionumber from MS/Excel 2 - Attempt to export records using this file 3 - It fails (mimetype is appliction/vnd.ms-excel) 4 - Apply patch 5 - Try again 6 - It succeeds! Signed-off-by: Jason Palmer <jpalmer@switchinc.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in v17.05.01 This patch has been pushed to 16.11.x and will be in 16.11.09. Pushed to 16.05.x, for 16.05.15 release |