| Summary: | Language selector in staff header menu similar to OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marc Véron <veron> |
| Component: | Staff interface | Assignee: | Marc Véron <veron> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 18718: Language selector in staff header menu similar to OPAC
Bug 18718: Language selector in staff header menu similar to OPAC [SIGNED-OFF] Bug 18718: Language selector in staff header menu similar to OPAC Bug 18718: Language selector in staff header menu similar to OPAC |
||
|
Description
Marc Véron
2017-06-02 08:30:28 UTC
Created attachment 63936 [details] [review] Bug 18718: Language selector in staff header menu similar to OPAC This patch adds a language selector menu to the top menu of staff client similar to the OPAC. Display of language selectors at top, bottom or both can be configured with system preference StaffLangSelectorModer. It defaults to bottom. To test: - Apply patch - Udate database - Restart plack and memchached - Go to staff client, verify that language selector displays at the bottom of the page (as before) - Go to system preferences, verify that there is a new preference StaffLanguageSelectorMode (name similar to the sypref ror OPAC), and that it is set to 'footer' - Change mode for top, both and footer and verify, go to staff client and verify for each that the language selector displays as appropriate This looks good, but I suggest one small change. Add a "dropdown-menu-right" class so that the menu doesn't disappear off the right side of the browser window with some installed languages with long labels like "English United Kingdom" <ul aria-labelledby="langmenu" role="menu" class="dropdown-menu dropdown-menu-right"> Created attachment 63938 [details] [review] Bug 18718: Language selector in staff header menu similar to OPAC This patch adds a language selector menu to the top menu of staff client similar to the OPAC. Display of language selectors at top, bottom or both can be configured with system preference StaffLangSelectorModer. It defaults to bottom. To test: - Apply patch - Udate database - Restart plack and memchached - Go to staff client, verify that language selector displays at the bottom of the page (as before) - Go to system preferences, verify that there is a new preference StaffLanguageSelectorMode (name similar to the sypref ror OPAC), and that it is set to 'footer' - Change mode for top, both and footer and verify, go to staff client and verify for each that the language selector displays as appropriate (Amended for comment #2 2017-06-02 mv) (In reply to Owen Leonard from comment #2) > This looks good, but I suggest one small change. Add a "dropdown-menu-right" > class so that the menu doesn't disappear off the right side of the browser > window with some installed languages with long labels like "English United > Kingdom" > > <ul aria-labelledby="langmenu" role="menu" class="dropdown-menu > dropdown-menu-right"> Thanks for the hint, Owen. I amended the patch, switching back to NSO. Created attachment 64019 [details] [review] [SIGNED-OFF] Bug 18718: Language selector in staff header menu similar to OPAC This patch adds a language selector menu to the top menu of staff client similar to the OPAC. Display of language selectors at top, bottom or both can be configured with system preference StaffLangSelectorModer. It defaults to bottom. To test: - Apply patch - Udate database - Restart plack and memchached - Go to staff client, verify that language selector displays at the bottom of the page (as before) - Go to system preferences, verify that there is a new preference StaffLanguageSelectorMode (name similar to the sypref ror OPAC), and that it is set to 'footer' - Change mode for top, both and footer and verify, go to staff client and verify for each that the language selector displays as appropriate (Amended for comment #2 2017-06-02 mv) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> QA: Looking here now Created attachment 66689 [details] [review] Bug 18718: Language selector in staff header menu similar to OPAC This patch adds a language selector menu to the top menu of staff client similar to the OPAC. Display of language selectors at top, bottom or both can be configured with system preference StaffLangSelectorModer. It defaults to bottom. To test: - Apply patch - Udate database - Restart plack and memchached - Go to staff client, verify that language selector displays at the bottom of the page (as before) - Go to system preferences, verify that there is a new preference StaffLanguageSelectorMode (name similar to the sypref ror OPAC), and that it is set to 'footer' - Change mode for top, both and footer and verify, go to staff client and verify for each that the language selector displays as appropriate (Amended for comment #2 2017-06-02 mv) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! Enhancement not pushed to 17.05.x |