| Summary: | Select All in Add Patron Option in Patron Lists only selects the first 20 entries | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Karen <karen> |
| Component: | Patrons | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | aspencatteam, fridolin.somers, gmcharlt, jendayi30, joonas.kylmala, kyle.m.hall, kyle, marjorie.barry-vila, patrick.robitaille, sally.healey, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05,20.11.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first 20 entries
Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first 20 entries Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first 20 entries |
||
|
Description
Karen
2017-06-07 16:03:47 UTC
Hi, Problem is still present in 17.05. Anyone works on this? Regards, Marjorie We have also noticed this behavior. It makes batch edits of patrons a clunky process of adding 20 at a time. Still valid. Still valid in 20.05 Still valid in 20.05 Created attachment 124193 [details] [review] Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first 20 entries This patch corrects the JavaScript functions for the "select all" and "clear all" action when viewing patrons in a list. Before this correction, checkboxes which were previously in hidden table rows would not be checked. To test, apply the patch and go to Patrons -> Patron Lists - View a patron list - If necessary, add multiple patrons to the list so that the number exceeds 20. - Change the number of entries shown by the DataTable: Show [ 50 ] entries. - Click "Select all." All visible checkboxes should be checked. - Click "Clear all." All checkboxes should be unchecked. Created attachment 124328 [details] [review] Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first 20 entries This patch corrects the JavaScript functions for the "select all" and "clear all" action when viewing patrons in a list. Before this correction, checkboxes which were previously in hidden table rows would not be checked. To test, apply the patch and go to Patrons -> Patron Lists - View a patron list - If necessary, add multiple patrons to the list so that the number exceeds 20. - Change the number of entries shown by the DataTable: Show [ 50 ] entries. - Click "Select all." All visible checkboxes should be checked. - Click "Clear all." All checkboxes should be unchecked. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Works as described. Created attachment 125024 [details] [review] Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first 20 entries This patch corrects the JavaScript functions for the "select all" and "clear all" action when viewing patrons in a list. Before this correction, checkboxes which were previously in hidden table rows would not be checked. To test, apply the patch and go to Patrons -> Patron Lists - View a patron list - If necessary, add multiple patrons to the list so that the number exceeds 20. - Change the number of entries shown by the DataTable: Show [ 50 ] entries. - Click "Select all." All visible checkboxes should be checked. - Click "Clear all." All checkboxes should be unchecked. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 Pushed to 20.11.x for 20.11.11 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |