| Summary: | ArticleRequests.t raises warnings | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> | 
| Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> | 
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> | 
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 18448 | ||
| Bug Blocks: | |||
| Attachments: | 
              Bug 18766: Remove itemtype-related warnings from ArticleRequests.t
               Bug 18766: Remove itemtype-related warnings from ArticleRequests.t  | 
      ||
| 
 
        
          Description
        
        
          Tomás Cohen Arazi (tcohen)
        
        
        
        
          2017-06-09 13:45:22 UTC
        
       
    Created attachment 64134 [details] [review] Bug 18766: Remove itemtype-related warnings from ArticleRequests.t This patch fixes a small mistake on that test file (itype vs. itemtype in itemtypes table) To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/ArticleRequests.t => FAIL: itemtype-related warning displayed - Apply the patch - Run k$ prove t/db_dependent/ArticleRequests.t => SUCCESS: No warnings, YAY! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 64135 [details] [review] Bug 18766: Remove itemtype-related warnings from ArticleRequests.t This patch fixes a small mistake on that test file (itype vs. itemtype in itemtypes table) To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/ArticleRequests.t => FAIL: itemtype-related warning displayed - Apply the patch - Run k$ prove t/db_dependent/ArticleRequests.t => SUCCESS: No warnings, YAY! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Trivial, skipping QA. Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 Patch doesn't apply cleanly to 16.11.x - please check if it's needed there and rebase. Problem here stems from the dependencies not being in 16.11.x, because they don't apply. Closing.  |