| Summary: | t/db_dependent/www/history.t is failing | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
| Component: | Test Suite | Assignee: | Mark Tompsett <mtompset> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, ldjamison |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 18773: Fix failing history.t test
[SIGNED OFF] Bug 18773: Fix failing history.t test Bug 18773: Fix failing history.t test |
||
|
Description
Mark Tompsett
2017-06-09 22:56:33 UTC
Created attachment 64168 [details] [review] Bug 18773: Fix failing history.t test changed get() to get_ok() and increased test count to match. Now the master build will only fail on search_utf8.t TEST PLAN --------- assuming KOHA_CONF is set. $ export KOHA_INTRANET_URL=... $ export KOHA_OPAC_URL=... $ prove -v t/db_dependent/www/history.t run koha qa test tools Applying the patch fixes the original problem with GETing the page. However, running prove -v t/db_dependant/www/history.t after patch application test 4 fails not ok 4 - Cyrillic characters with umlauts show correctly on the history page. # Failed test 'Cyrillic characters with umlauts show correctly on the history page.' # at t/db_dependent/www/history.t line 65. Check the about.pl page -- The timeline is probably mostly blank. I replicated this problem on the kohadevbox. On an old school git install, the 4th test passes, because the history.txt file is found, and so is that translator's name. :) Make sure /usr/share/doc/koha-common/history.txt (or some path similar to this) exists, if you find your the about.pl timeline tab mostly empty. (In reply to M. Tompsett from comment #4) > Make sure /usr/share/doc/koha-common/history.txt (or some path similar to > this) exists, if you find your the about.pl timeline tab mostly empty. Thank you for the advice! It turned out that there must have been a misconfiguration but after I ran reset_all in kohadevbox your patch works correctly after applying it so I will sign off on it Created attachment 64174 [details] [review] [SIGNED OFF] Bug 18773: Fix failing history.t test changed get() to get_ok() and increased test count to match. Now the master build will only fail on search_utf8.t TEST PLAN --------- assuming KOHA_CONF is set. $ export KOHA_INTRANET_URL=... $ export KOHA_OPAC_URL=... $ prove -v t/db_dependent/www/history.t run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Works correctly using text plan provided and passes QA tools. The tests pass for me, but the changes make sense (get only takes 1 parameter). It will certainly not fix Jenkins failures. Created attachment 64200 [details] [review] Bug 18773: Fix failing history.t test changed get() to get_ok() and increased test count to match. Now the master build will only fail on search_utf8.t TEST PLAN --------- assuming KOHA_CONF is set. $ export KOHA_INTRANET_URL=... $ export KOHA_OPAC_URL=... $ prove -v t/db_dependent/www/history.t run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Works correctly using text plan provided and passes QA tools. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 This patch has been pushed to 16.11.x and will be in 16.11.09. Very excited to see those - hope they will turn Jenkins green! |