Summary: | Translatability: Get rid of tt directive in translation for item-status.inc | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 18778 - Translatability: Get rid of tt directive in translation for item-status.inc
[SIGNED-OFF] Bug 18778 - Translatability: Get rid of tt directive in translation for item-status.inc Bug 18778 - Translatability: Get rid of tt directive in translation for item-status.inc |
Description
Marc Véron
2017-06-12 05:48:16 UTC
Created attachment 64189 [details] [review] Bug 18778 - Translatability: Get rid of tt directive in translation for item-status.inc The file opac-tmpl/bootstrap/en/includes/item-status.inc exposes a template directive where translators should not be confronted with. "%s %s [%%#- This include takes two parameters: an item structure and an " "optional loan (issue) structure. The issue structure is used by course " "reserves pages, which do not use an API to fetch items that populates item." "datedue. -%%] %s %s %s %s " This patch fixes new lines inside a tt directive (comment). It is merely a string patch. To test: Verify that the code changes make sense. (Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po) Created attachment 64736 [details] [review] [SIGNED-OFF] Bug 18778 - Translatability: Get rid of tt directive in translation for item-status.inc The file opac-tmpl/bootstrap/en/includes/item-status.inc exposes a template directive where translators should not be confronted with. "%s %s [%%#- This include takes two parameters: an item structure and an " "optional loan (issue) structure. The issue structure is used by course " "reserves pages, which do not use an API to fetch items that populates item." "datedue. -%%] %s %s %s %s " This patch fixes new lines inside a tt directive (comment). It is merely a string patch. To test: Verify that the code changes make sense. (Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po) NOTE: Followed test plan similar to bug 18776 comment 3. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 66645 [details] [review] Bug 18778 - Translatability: Get rid of tt directive in translation for item-status.inc The file opac-tmpl/bootstrap/en/includes/item-status.inc exposes a template directive where translators should not be confronted with. "%s %s [%%#- This include takes two parameters: an item structure and an " "optional loan (issue) structure. The issue structure is used by course " "reserves pages, which do not use an API to fetch items that populates item." "datedue. -%%] %s %s %s %s " This patch fixes new lines inside a tt directive (comment). It is merely a string patch. To test: Verify that the code changes make sense. (Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po) NOTE: Followed test plan similar to bug 18776 comment 3. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.04. This patch has been pushed to 16.11.x and will be in 16.11.12. Pushed to 16.05.x, for 16.05.17 release |