Summary: | Translatability: Get rid of exposed tt directive in masthead-langmenu.inc | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | I18N/L10N | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 18780: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc
[SIGNED-OFF] Bug 18780: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc Bug 18780: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc |
Description
Marc Véron
2017-06-12 06:40:51 UTC
Created attachment 64191 [details] [review] Bug 18780: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc The file opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc exposes following tt directive to translators: "[%% IF ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && " "( languages_loop ) && ( OpacLangSelectorMode == 'both' || " "OpacLangSelectorMode == 'top') ) %%] " This patch fixes it. To test: - Apply patch - Verify that language selector in OPAC (top of the page) works as expected - Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po Created attachment 64737 [details] [review] [SIGNED-OFF] Bug 18780: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc The file opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc exposes following tt directive to translators: "[%% IF ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && " "( languages_loop ) && ( OpacLangSelectorMode == 'both' || " "OpacLangSelectorMode == 'top') ) %%] " This patch fixes it. To test: - Apply patch - Verify that language selector in OPAC (top of the page) works as expected - Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po NOTE: Followed a test plan similar to bug 18776 comment 3 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 66644 [details] [review] Bug 18780: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc The file opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc exposes following tt directive to translators: "[%% IF ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && " "( languages_loop ) && ( OpacLangSelectorMode == 'both' || " "OpacLangSelectorMode == 'top') ) %%] " This patch fixes it. To test: - Apply patch - Verify that language selector in OPAC (top of the page) works as expected - Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po NOTE: Followed a test plan similar to bug 18776 comment 3 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.05. This patch has been pushed to 16.11.x and will be in 16.11.13. Pushed to 16.05.x, for 16.05.18 release |