Bug 1879

Summary: Managing Suggestions - no way to edit
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: AcquisitionsAssignee: Henri-Damien LAURENT <henridamien>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: PATCH-Sent (DO NOT USE)    
Version: rel_3_0   
Hardware: Macintosh   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: reason not changing
mass changing isn't working
hdl's has no for all three on the pending tab
mine shows no for the tab you're on - no pending
mine shows no for the tab you're on - no accepted

Description Chris Cormack 2010-05-21 00:35:40 UTC


---- Reported by nengard@gmail.com 2008-02-25 15:55:10 ----

If you accidentally approved or rejected a suggestion, then there is no way to edit the suggestion after the fact.



---- Additional Comments From henridamien@koha-fr.org 2008-03-15 15:01:30 ----

Patch sent to Owen for some js improvements.



---- Additional Comments From henridamien@koha-fr.org 2008-04-17 01:09:40 ----

Patch sent on 14-04



---- Additional Comments From nengard@gmail.com 2008-04-17 06:43:45 ----

When changing status it doesn't seem to change what appears under the reason - see image one - after changing the pull down and clicking submit it stays the same.

Also, when I click mark all with this reason nothing happens - see image 2

Lastly, after I change a rejected order it brings me back to the pending tab - making me click on rejected again - not terribly user-friendly



---- Additional Comments From nengard@gmail.com 2008-04-17 06:44:08 ----

Created an attachment
reason not changing





---- Additional Comments From nengard@gmail.com 2008-04-17 06:44:34 ----

Created an attachment
mass changing isn't working





---- Additional Comments From nengard@gmail.com 2008-04-17 06:46:07 ----

Another note - my manage suggestions page looks different from HDL's - I actually like the way mine looks better - but either way - it's not all the same.  See two images.



---- Additional Comments From nengard@gmail.com 2008-04-17 06:46:42 ----

Created an attachment
hdl's has no for all three on the pending tab





---- Additional Comments From nengard@gmail.com 2008-04-17 06:47:20 ----

Created an attachment
mine shows no for the tab you're on - no pending





---- Additional Comments From nengard@gmail.com 2008-04-17 06:47:41 ----

Created an attachment
mine shows no for the tab you're on - no accepted





---- Additional Comments From nengard@gmail.com 2008-04-24 10:18:40 ----

I can now update reasons en-mass, but I still don't see any accepted suggestions - even if I have accepted some.

Also, when I visit the rejected page the reasons for rejecting (that I entered on the pending tab) are not displaying.



---- Additional Comments From nengard@gmail.com 2008-04-24 10:23:46 ----

Nevermind my comment about approved items not showing up - that works, but when I visit the rejected page the reasons for rejecting (that I entered
on the pending tab) are not displaying.



---- Additional Comments From henridamien@koha-fr.org 2008-04-24 10:24:49 ----

Have you upgraded yui ?



---- Additional Comments From nengard@gmail.com 2008-04-24 10:44:14 ----

from josh:

the answer is yes :-) did you shift-refresh is another question.



---- Additional Comments From nengard@gmail.com 2008-04-24 10:45:34 ----

Okay - I figured it out.  Here are the steps

Reject a suggestion
Suggestion appears on rejected tab with reason
Delete a rejected suggestion
Suggestion no longer has a reason attached to it



---- Additional Comments From jmf@liblime.com 2008-05-19 12:55:12 ----

Marking this as fixed, thanks Henri-Damien!



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:35 UTC  ---

This bug was previously known as _bug_ 1879 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1879
Imported an attachment (id=394)
Imported an attachment (id=395)
Imported an attachment (id=396)
Imported an attachment (id=397)
Imported an attachment (id=398)

Actual time not defined. Setting to 0.0
The original submitter of attachment 394 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 395 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 396 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 397 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 398 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.