Bug 18797

Summary: t/db_dependent/rollingloans.t is skipping
Product: Koha Reporter: Mark Tompsett <mtompset>
Component: Test SuiteAssignee: Mark Tompsett <mtompset>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, ldjamison, m.de.rooy, mtompset
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 18797: Make rollingloans test useful
Bug 18797: Make rollingloans test useful
Bug 18797: Create the biblioitem entry

Description Mark Tompsett 2017-06-13 16:27:29 UTC
t/db_dependent/rollingloans.t is need of a refactor using TestBuilder to correct its current lack of usefulness.
Comment 1 Marcel de Rooy 2017-08-10 06:47:36 UTC
Looks good to me LOL

ok 1 # skip Missing test borrower or item, skipping tests
ok 2 # skip Missing test borrower or item, skipping tests
ok 3 # skip Missing test borrower or item, skipping tests
ok 4 # skip Missing test borrower or item, skipping tests
ok 5 # skip Missing test borrower or item, skipping tests
ok 6 # skip Missing test borrower or item, skipping tests
ok 7 # skip Missing test borrower or item, skipping tests
ok 8 # skip Missing test borrower or item, skipping tests
Comment 2 Jonathan Druart 2017-08-10 14:36:29 UTC
Marcel, yes that is the problem. The tests are never executed, data are not created.
Comment 3 Mark Tompsett 2018-03-17 02:27:26 UTC
Created attachment 73065 [details] [review]
Bug 18797: Make rollingloans test useful

TEST PLAN
---------
1) Run the following commands on a kohadevbox:
    kshell
    prove -v t/db_dependent/rollingloans.t
    exit
   -- all the tests were skipped, not useful!
2) Apply this patch
3) Redo step 1
   -- all the tests run
4) Run qa test tools
Comment 4 Marcel de Rooy 2018-03-21 12:54:12 UTC
Created attachment 73137 [details] [review]
Bug 18797: Make rollingloans test useful

TEST PLAN
---------
1) Run the following commands on a kohadevbox:
    kshell
    prove -v t/db_dependent/rollingloans.t
    exit
   -- all the tests were skipped, not useful!
2) Apply this patch
3) Redo step 1
   -- all the tests run
4) Run qa test tools

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2018-03-21 12:55:22 UTC
Combining SO/QA for simple unit test improvement
Comment 6 Jonathan Druart 2018-03-26 20:11:49 UTC
Created attachment 73294 [details] [review]
Bug 18797: Create the biblioitem entry

We need that since bug 19943
Comment 7 Jonathan Druart 2018-03-26 20:35:14 UTC
Pushed to master for 18.05, thanks to everybody involved!